`kubernetes_cluster` `kubernetes_cluster_node_pool` - `message_of_day` `scale_down_mode` `workload_runtime` `load_balancer_profile/managed_outbound_ipv6_count` #16741

qiqingzhang · 2022-05-11T05:23:51Z

public pr for `kubernetes_cluster` `kubernetes_cluster_node_pool` - `message_of_day` `scale_down_mode` `workload_runtime` `load_balancer_profile/managed_outbound_ipv6_count`

test result after update：

1：TestAccKubernetesCluster_nodePoolOther

2：TestAccKubernetesCluster_scaleDownMode：

3：TestAccKubernetesClusterNodePool_other：

…cording test

stephybun

Thanks for this PR @qiqingzhang I left some suggestions in-line regarding the property names and documentation. Once they're fixed up we can take another look over this!

stephybun · 2022-07-11T04:52:01Z

internal/services/containers/kubernetes_cluster_node_pool_resource.go

+			"message_of_day": {
+				Type:         pluginsdk.TypeString,
+				Optional:     true,
+				ForceNew:     true,


Should this be ForceNew since we're checking for changes and updating the value below?

It can't be updated, I'll remove the codes checking for changes and updating.

stephybun · 2022-07-14T02:17:20Z

internal/services/containers/kubernetes_cluster_node_pool_resource.go

@@ -155,6 +156,13 @@ func resourceKubernetesClusterNodePool() *pluginsdk.Resource {
 				ForceNew: true,
 			},

+			"message_of_day": {


I think this would be clearer as message_of_the_day

stephybun · 2022-07-14T04:03:10Z

internal/services/containers/kubernetes_nodepool.go

@@ -115,6 +116,13 @@ func SchemaDefaultNodePool() *pluginsdk.Schema {
 						ForceNew: true,
 					},

+					"message_of_day": {


Same here

Suggested change

"message_of_day": {

"message_of_the_day": {

stephybun · 2022-07-14T04:06:51Z

internal/services/containers/kubernetes_nodepool.go

+	if scaleOfMode := raw["scale_down_mode"].(string); scaleOfMode != "" {
+		profile.ScaleDownMode = containerservice.ScaleDownMode(scaleOfMode)


Suggested change

if scaleOfMode := raw["scale_down_mode"].(string); scaleOfMode != "" {

profile.ScaleDownMode = containerservice.ScaleDownMode(scaleOfMode)

if scaleDownMode := raw["scale_down_mode"].(string); scaleDownMode != "" {

profile.ScaleDownMode = containerservice.ScaleDownMode(scaleDownMode)

stephybun · 2022-07-14T04:09:44Z

website/docs/r/kubernetes_cluster.html.markdown

@@ -336,6 +336,8 @@ A `default_node_pool` block supports the following:

 * `max_pods` - (Optional) The maximum number of pods that can run on each agent. Changing this forces a new resource to be created.

+* `message_of_day` - (Optional) A base64-encoded string which will be written to /etc/motd after decoding. This allows customization of the message of the day for Linux nodes. It must not be specified for Windows nodes. It must be a static string (i.e., will be printed raw and not be executed as a script). Changing this forces a new resource to be created.


If this can't be supplied for Windows nodes could we add a safeguard to prevent that in the create function?

Suggested change

* `message_of_day` - (Optional) A base64-encoded string which will be written to /etc/motd after decoding. This allows customization of the message of the day for Linux nodes. It must not be specified for Windows nodes. It must be a static string (i.e., will be printed raw and not be executed as a script). Changing this forces a new resource to be created.

* `message_of_the_day` - (Optional) A base64-encoded string which will be written to /etc/motd after decoding. This allows customization of the message of the day for Linux nodes. It cannot be specified for Windows nodes and must be a static string (i.e. will be printed raw and not executed as a script). Changing this forces a new resource to be created.

stephybun · 2022-07-14T04:11:48Z

website/docs/r/kubernetes_cluster.html.markdown

@@ -356,6 +358,8 @@ A `default_node_pool` block supports the following:

 -> **Note:** This requires that the Preview Feature `Microsoft.ContainerService/PodSubnetPreview` is enabled and the Resource Provider is re-registered, see [the documentation](https://docs.microsoft.com/azure/aks/configure-azure-cni#register-the-podsubnetpreview-preview-feature) for more information.

+* `scale_down_mode` - (Optional) This also effects the cluster autoscaler behavior. If not specified, it defaults to Delete. Possible values include: 'ScaleDownModeDelete', 'ScaleDownModeDeallocate'. Changing this forces a new resource to be created.


Suggested change

* `scale_down_mode` - (Optional) This also effects the cluster autoscaler behavior. If not specified, it defaults to Delete. Possible values include: 'ScaleDownModeDelete', 'ScaleDownModeDeallocate'. Changing this forces a new resource to be created.

* `scale_down_mode` - (Optional) Specifies the autoscaling behaviour of the Kubernetes Cluster. If not specified, it defaults to 'ScaleDownModeDelete'. Possible values include 'ScaleDownModeDelete' and 'ScaleDownModeDeallocate'. Changing this forces a new resource to be created.

stephybun · 2022-07-14T04:12:43Z

website/docs/r/kubernetes_cluster.html.markdown

@@ -386,6 +390,8 @@ If `enable_auto_scaling` is set to `false`, then the following fields can also b

 -> **Note:** If `enable_auto_scaling` is set to `false` both `min_count` and `max_count` fields need to be set to `null` or omitted from the configuration.

+* `workload_runtime` - (Optional) Used to specify the workload runtime. Allowed values are `OCIContainer`.


Suggested change

* `workload_runtime` - (Optional) Used to specify the workload runtime. Allowed values are `OCIContainer`.

* `workload_runtime` - (Optional) Specifies the workload runtime used by the node pool. Possible values are `OCIContainer`.

stephybun · 2022-07-14T04:14:56Z

website/docs/r/kubernetes_cluster.html.markdown

@@ -548,6 +554,8 @@ A `load_balancer_profile` block supports the following:

 * `managed_outbound_ip_count` - (Optional) Count of desired managed outbound IPs for the cluster load balancer. Must be between `1` and `100` inclusive.

+* `managed_outbound_ipv6_count` - (Optional) The desired number of IPv6 outbound IPs created/managed by Azure for the cluster load balancer. Allowed values must be in the range of 1 to 100 (inclusive). The default value is 0 for single-stack and 1 for dual-stack.


If I recall dual-stack is still a preview feature that needs to be enabled in order for this to work - should we add a note below explaining this?

Suggested change

* `managed_outbound_ipv6_count` - (Optional) The desired number of IPv6 outbound IPs created/managed by Azure for the cluster load balancer. Allowed values must be in the range of 1 to 100 (inclusive). The default value is 0 for single-stack and 1 for dual-stack.

* `managed_outbound_ipv6_count` - (Optional) The desired number of IPv6 outbound IPs created and managed by Azure for the cluster load balancer. Must be in the range of 1 to 100 (inclusive). The default value is 0 for single-stack and 1 for dual-stack.

stephybun · 2022-07-14T04:15:37Z

website/docs/r/kubernetes_cluster_node_pool.html.markdown

@@ -97,6 +97,8 @@ The following arguments are supported:

 * `max_pods` - (Optional) The maximum number of pods that can run on each agent. Changing this forces a new resource to be created.

+* `message_of_day` - (Optional) A base64-encoded string which will be written to /etc/motd after decoding. This allows customization of the message of the day for Linux nodes. It must not be specified for Windows nodes. It must be a static string (i.e., will be printed raw and not be executed as a script). Changing this forces a new resource to be created.


Suggested change

* `message_of_day` - (Optional) A base64-encoded string which will be written to /etc/motd after decoding. This allows customization of the message of the day for Linux nodes. It must not be specified for Windows nodes. It must be a static string (i.e., will be printed raw and not be executed as a script). Changing this forces a new resource to be created.

* `message_of_the_day` - (Optional) A base64-encoded string which will be written to /etc/motd after decoding. This allows customization of the message of the day for Linux nodes. It cannot be specified for Windows nodes and must be a static string (i.e. will be printed raw and not executed as a script). Changing this forces a new resource to be created.

ms-henglu · 2022-07-14T05:42:24Z

Hi @stephybun , thank you for code review, I've updated the PR as suggested, please take another look, thanks!

stephybun

Thanks @qiqingzhang and @ms-henglu LGTM ✨

github-actions · 2022-10-11T19:04:28Z

This functionality has been released in v3.26.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2022-11-11T02:32:46Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

qiqingzhang added 7 commits May 10, 2022 13:21

[init](aks_cluster/node_pool): supports props

b86afde

[add]add messageOfDay in aks_cluster_node_pool

864e3ff

[style] remove uselless line

0d65663

[fix] fix message of the day to base 64(encoded) and add foece new ac…

9f869d9

…cording test

[style] clean up code

bd2ba71

[fix] workload_runtime can't be WasmWasi.

2874cd2

[modify] improve code

f0c75a3

github-actions bot added documentation size/L labels May 11, 2022

tombuildsstuff requested a review from stephybun June 29, 2022 17:15

ms-henglu and others added 3 commits July 7, 2022 10:08

Merge branch 'main' into feat-aks_cluster/aks_agent_pool-supports-props

12f1732

Merge branch 'main' into feat-aks_cluster/aks_agent_pool-supports-props

90e8901

fix golint

83afcec

stephybun requested changes Jul 14, 2022

View reviewed changes

update

89bc5fe

Merge branch 'main' into feat-aks_cluster/aks_agent_pool-supports-props

ff3509a

katbyte added the service/kubernetes-cluster label Sep 21, 2022

stephybun added 2 commits October 6, 2022 16:08

fix wording in docs

b5d8cfb

Merge branch 'main' into feat-aks_cluster/aks_agent_pool-supports-props

07ef1e6

stephybun approved these changes Oct 6, 2022

View reviewed changes

stephybun merged commit fa66a4b into hashicorp:main Oct 6, 2022

github-actions bot added this to the v3.26.0 milestone Oct 6, 2022

stephybun added a commit that referenced this pull request Oct 6, 2022

Update for #16741

840b8fb

github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`kubernetes_cluster` `kubernetes_cluster_node_pool` - `message_of_day` `scale_down_mode` `workload_runtime` `load_balancer_profile/managed_outbound_ipv6_count` #16741

`kubernetes_cluster` `kubernetes_cluster_node_pool` - `message_of_day` `scale_down_mode` `workload_runtime` `load_balancer_profile/managed_outbound_ipv6_count` #16741

qiqingzhang commented May 11, 2022

stephybun left a comment

stephybun Jul 11, 2022

ms-henglu Jul 14, 2022

stephybun Jul 14, 2022

stephybun Jul 14, 2022

stephybun Jul 14, 2022

stephybun Jul 14, 2022

stephybun Jul 14, 2022

stephybun Jul 14, 2022

stephybun Jul 14, 2022

stephybun Jul 14, 2022

ms-henglu commented Jul 14, 2022

stephybun left a comment

github-actions bot commented Oct 11, 2022

github-actions bot commented Nov 11, 2022

		if scaleOfMode := raw["scale_down_mode"].(string); scaleOfMode != "" {
		profile.ScaleDownMode = containerservice.ScaleDownMode(scaleOfMode)

		@@ -336,6 +336,8 @@ A `default_node_pool` block supports the following:

		* `max_pods` - (Optional) The maximum number of pods that can run on each agent. Changing this forces a new resource to be created.

		* `message_of_day` - (Optional) A base64-encoded string which will be written to /etc/motd after decoding. This allows customization of the message of the day for Linux nodes. It must not be specified for Windows nodes. It must be a static string (i.e., will be printed raw and not be executed as a script). Changing this forces a new resource to be created.

	* `message_of_day` - (Optional) A base64-encoded string which will be written to /etc/motd after decoding. This allows customization of the message of the day for Linux nodes. It must not be specified for Windows nodes. It must be a static string (i.e., will be printed raw and not be executed as a script). Changing this forces a new resource to be created.
	* `message_of_the_day` - (Optional) A base64-encoded string which will be written to /etc/motd after decoding. This allows customization of the message of the day for Linux nodes. It cannot be specified for Windows nodes and must be a static string (i.e. will be printed raw and not executed as a script). Changing this forces a new resource to be created.

		@@ -356,6 +358,8 @@ A `default_node_pool` block supports the following:

		-> Note: This requires that the Preview Feature `Microsoft.ContainerService/PodSubnetPreview` is enabled and the Resource Provider is re-registered, see [the documentation](https://docs.microsoft.com/azure/aks/configure-azure-cni#register-the-podsubnetpreview-preview-feature) for more information.

		* `scale_down_mode` - (Optional) This also effects the cluster autoscaler behavior. If not specified, it defaults to Delete. Possible values include: 'ScaleDownModeDelete', 'ScaleDownModeDeallocate'. Changing this forces a new resource to be created.

	* `scale_down_mode` - (Optional) This also effects the cluster autoscaler behavior. If not specified, it defaults to Delete. Possible values include: 'ScaleDownModeDelete', 'ScaleDownModeDeallocate'. Changing this forces a new resource to be created.
	* `scale_down_mode` - (Optional) Specifies the autoscaling behaviour of the Kubernetes Cluster. If not specified, it defaults to 'ScaleDownModeDelete'. Possible values include 'ScaleDownModeDelete' and 'ScaleDownModeDeallocate'. Changing this forces a new resource to be created.

		@@ -386,6 +390,8 @@ If `enable_auto_scaling` is set to `false`, then the following fields can also b

		-> Note: If `enable_auto_scaling` is set to `false` both `min_count` and `max_count` fields need to be set to `null` or omitted from the configuration.

		* `workload_runtime` - (Optional) Used to specify the workload runtime. Allowed values are `OCIContainer`.

	* `workload_runtime` - (Optional) Used to specify the workload runtime. Allowed values are `OCIContainer`.
	* `workload_runtime` - (Optional) Specifies the workload runtime used by the node pool. Possible values are `OCIContainer`.

		@@ -548,6 +554,8 @@ A `load_balancer_profile` block supports the following:

		* `managed_outbound_ip_count` - (Optional) Count of desired managed outbound IPs for the cluster load balancer. Must be between `1` and `100` inclusive.

		* `managed_outbound_ipv6_count` - (Optional) The desired number of IPv6 outbound IPs created/managed by Azure for the cluster load balancer. Allowed values must be in the range of 1 to 100 (inclusive). The default value is 0 for single-stack and 1 for dual-stack.

		@@ -97,6 +97,8 @@ The following arguments are supported:

		* `max_pods` - (Optional) The maximum number of pods that can run on each agent. Changing this forces a new resource to be created.

		* `message_of_day` - (Optional) A base64-encoded string which will be written to /etc/motd after decoding. This allows customization of the message of the day for Linux nodes. It must not be specified for Windows nodes. It must be a static string (i.e., will be printed raw and not be executed as a script). Changing this forces a new resource to be created.

kubernetes_cluster kubernetes_cluster_node_pool - message_of_day scale_down_mode workload_runtime load_balancer_profile/managed_outbound_ipv6_count #16741

kubernetes_cluster kubernetes_cluster_node_pool - message_of_day scale_down_mode workload_runtime load_balancer_profile/managed_outbound_ipv6_count #16741

Conversation

qiqingzhang commented May 11, 2022

public pr for kubernetes_cluster kubernetes_cluster_node_pool - message_of_day scale_down_mode workload_runtime load_balancer_profile/managed_outbound_ipv6_count

stephybun left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ms-henglu commented Jul 14, 2022

stephybun left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 11, 2022

github-actions bot commented Nov 11, 2022

`kubernetes_cluster` `kubernetes_cluster_node_pool` - `message_of_day` `scale_down_mode` `workload_runtime` `load_balancer_profile/managed_outbound_ipv6_count` #16741

`kubernetes_cluster` `kubernetes_cluster_node_pool` - `message_of_day` `scale_down_mode` `workload_runtime` `load_balancer_profile/managed_outbound_ipv6_count` #16741

public pr for `kubernetes_cluster` `kubernetes_cluster_node_pool` - `message_of_day` `scale_down_mode` `workload_runtime` `load_balancer_profile/managed_outbound_ipv6_count`