azurerm_[linux|windows]_web_app and azurerm_[linux|windows]_web_app_slot - add support for zip deployment

[jackofallops]

This PR adds support for deploying local zip packaged apps as described in the Azure docs here.

• azurerm_linux_web_app - Add support for zip_deploy_file property
• azurerm_linux_web_app_slot - Add support for zip_deploy_file property
• azurerm_windows_web_app - Add support for zip_deploy_file property
• azurerm_windows_web_app_slot - Add support for zip_deploy_file property

[katbyte]

LGTM 🦀

[jackofallops]

Tests look good

[Stolpe]

Hi,

I know that this is now merged and accepted, but would it not have been preferred to model this as a separate resource? In many use cases, one would probably want to perform some kind of configuration transformation on appsettings.json or web.config prior to deploying it, and this transformation is likely partly based on output from Terraform.

Wouldn't it have been better to have modeled this similarly to eg. the azurerm_app_service_active_slot resource. I use that resource with an extra parameter, which activates the swap on a second run with the otherwise same variables, which triggers the swap. That would have been a viable solution here too, but now since it's a property, wouldn't that be a lot harder?

resource "azurerm_app_service_active_slot" "app_service_api_active_slot" {
  count = var.app_service_slot_swap ? 1 : 0

  resource_group_name   = azurerm_app_service_slot.app_service_api_staging_slot.resource_group_name
  app_service_name      = azurerm_app_service_slot.app_service_api_staging_slot.app_service_name
  app_service_slot_name = azurerm_app_service_slot.app_service_api_staging_slot.name
}

[github-actions]

This functionality has been released in v3.8.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.