Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] azurerm_redis_cache - support config identity #16990

Merged
merged 2 commits into from
Jun 2, 2022

Conversation

xuzhang3
Copy link
Contributor

Add support configuring SystemAssigned, UserAssigned identities for azurerm_redis_cache

=== RUN   TestAccRedisCache_identity
=== PAUSE TestAccRedisCache_identity
=== CONT  TestAccRedisCache_identity
--- PASS: TestAccRedisCache_identity (2064.65s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/redis 2066.745s
=== RUN   TestAccRedisCache_BackupEnabledDisabled
=== PAUSE TestAccRedisCache_BackupEnabledDisabled
=== CONT  TestAccRedisCache_BackupEnabledDisabled
--- PASS: TestAccRedisCache_BackupEnabledDisabled (1375.91s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/redis (cached)
=== RUN   TestAccRedisCache_basic
=== PAUSE TestAccRedisCache_basic
=== CONT  TestAccRedisCache_basic
--- PASS: TestAccRedisCache_basic (1892.95s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/redis 1895.231s
=== RUN   TestAccRedisCache_premium
=== PAUSE TestAccRedisCache_premium
=== RUN   TestAccRedisCache_premiumSharded
=== PAUSE TestAccRedisCache_premiumSharded
=== RUN   TestAccRedisCache_premiumShardedScaling
=== PAUSE TestAccRedisCache_premiumShardedScaling
=== CONT  TestAccRedisCache_premium
=== CONT  TestAccRedisCache_premiumShardedScaling
=== CONT  TestAccRedisCache_premiumSharded
--- PASS: TestAccRedisCache_premium (1303.34s)
--- PASS: TestAccRedisCache_premiumSharded (1350.14s)
--- PASS: TestAccRedisCache_premiumShardedScaling (2615.91s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/redis 2617.864s

Signed-off-by: Zooopx <xuzhang3@microsoft.com>
Signed-off-by: Zooopx <xuzhang3@microsoft.com>
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xuzhang3 - LGTGM 🌿

@katbyte katbyte merged commit eddd5b2 into hashicorp:main Jun 2, 2022
@github-actions github-actions bot added this to the v3.9.0 milestone Jun 2, 2022
katbyte added a commit that referenced this pull request Jun 2, 2022
@github-actions
Copy link

github-actions bot commented Jun 3, 2022

This functionality has been released in v3.9.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jul 4, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants