Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New data source: azurerm_app_configuration_keys #17053

Merged

Conversation

favoretti
Copy link
Collaborator

@favoretti favoretti commented Jun 1, 2022

azurerm_app_configuration_key only allows one to fetch a single key. This datasource allows fetching multiple, depending on keynames and/or labels.

$ TF_ACC=1 go test -v ./internal/services/appconfiguration -timeout=1000m -run='TestAccAppConfigurationKeysDataSource'
=== RUN   TestAccAppConfigurationKeysDataSource_allkeys
=== PAUSE TestAccAppConfigurationKeysDataSource_allkeys
=== RUN   TestAccAppConfigurationKeysDataSource_key
=== PAUSE TestAccAppConfigurationKeysDataSource_key
=== RUN   TestAccAppConfigurationKeysDataSource_label
=== PAUSE TestAccAppConfigurationKeysDataSource_label
=== CONT  TestAccAppConfigurationKeysDataSource_allkeys
=== CONT  TestAccAppConfigurationKeysDataSource_label
=== CONT  TestAccAppConfigurationKeysDataSource_key
--- PASS: TestAccAppConfigurationKeysDataSource_label (185.92s)
--- PASS: TestAccAppConfigurationKeysDataSource_allkeys (186.80s)
--- PASS: TestAccAppConfigurationKeysDataSource_key (187.03s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/appconfiguration	188.136s

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦋

@katbyte katbyte merged commit fee5ddb into hashicorp:main Jun 2, 2022
katbyte added a commit that referenced this pull request Jun 2, 2022
@github-actions github-actions bot added this to the v3.9.0 milestone Jun 2, 2022
@github-actions
Copy link

github-actions bot commented Jun 3, 2022

This functionality has been released in v3.9.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jul 4, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants