-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add api_management_gateway_hostname_configuration #17166
Add api_management_gateway_hostname_configuration #17166
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dvob - overall this looks good but we need to fix up the tests:
a5968bd
to
70c1c2e
Compare
b3101b0
to
3fbbb87
Compare
Removed the resource as it was already added in #17962 with slightly different name, and renamed data source to match |
2d7596e
to
7e49695
Compare
website/docs/d/api_management_gateway_host_name_configuration.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/d/api_management_gateway_host_name_configuration.html.markdown
Show resolved
Hide resolved
7e49695
to
e9ce3e6
Compare
e9ce3e6
to
5385732
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dvob and @manicminer LGTM 🍕
@manicminer Thank you for finalizing this PR |
This functionality has been released in v3.29.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Add support for hostConfigurations in API management gateways.
For this I took more or less the
api_management_gateway
resource and data source as a template and adjusted it accordingly.Unfortunately I can't run the integration tests because I don't have a client_id and client_secret to access an Azure tenant.