Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add api_management_gateway_hostname_configuration #17166

Merged
merged 6 commits into from
Oct 26, 2022

Conversation

dvob
Copy link
Contributor

@dvob dvob commented Jun 8, 2022

Add support for hostConfigurations in API management gateways.
For this I took more or less the api_management_gateway resource and data source as a template and adjusted it accordingly.
Unfortunately I can't run the integration tests because I don't have a client_id and client_secret to access an Azure tenant.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dvob - overall this looks good but we need to fix up the tests:

image

@manicminer manicminer force-pushed the gateway_hostname_configuration branch 2 times, most recently from b3101b0 to 3fbbb87 Compare October 20, 2022 20:56
@manicminer
Copy link
Member

Removed the resource as it was already added in #17962 with slightly different name, and renamed data source to match

@manicminer manicminer force-pushed the gateway_hostname_configuration branch 2 times, most recently from 2d7596e to 7e49695 Compare October 20, 2022 21:29
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dvob and @manicminer LGTM 🍕

@stephybun stephybun merged commit a1debf1 into hashicorp:main Oct 26, 2022
@github-actions github-actions bot added this to the v3.29.0 milestone Oct 26, 2022
stephybun added a commit that referenced this pull request Oct 26, 2022
@dvob
Copy link
Contributor Author

dvob commented Oct 27, 2022

@manicminer Thank you for finalizing this PR

@github-actions
Copy link

This functionality has been released in v3.29.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants