Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data.azurerm_storage_account - add supports of identity #17215

Merged
merged 1 commit into from Jun 23, 2022

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Jun 13, 2022

Fix #17171

Test

💢  TF_ACC=1 go test -v -timeout=20h ./internal/services/storage -run='TestAccDataSourceStorageAccount_.*Identity'
=== RUN   TestAccDataSourceStorageAccount_systemAssignedIdentity
=== PAUSE TestAccDataSourceStorageAccount_systemAssignedIdentity
=== RUN   TestAccDataSourceStorageAccount_userAssignedIdentity
=== PAUSE TestAccDataSourceStorageAccount_userAssignedIdentity
=== RUN   TestAccDataSourceStorageAccount_systemAssignedUserAssignedIdentity
=== PAUSE TestAccDataSourceStorageAccount_systemAssignedUserAssignedIdentity
=== CONT  TestAccDataSourceStorageAccount_systemAssignedIdentity
=== CONT  TestAccDataSourceStorageAccount_systemAssignedUserAssignedIdentity
=== CONT  TestAccDataSourceStorageAccount_userAssignedIdentity
--- PASS: TestAccDataSourceStorageAccount_systemAssignedIdentity (94.45s)
--- PASS: TestAccDataSourceStorageAccount_systemAssignedUserAssignedIdentity (109.28s)
--- PASS: TestAccDataSourceStorageAccount_userAssignedIdentity (178.50s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/storage       178.518s

Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jackofallops jackofallops merged commit 7b06052 into hashicorp:main Jun 23, 2022
jackofallops added a commit that referenced this pull request Jun 23, 2022
@github-actions
Copy link

This functionality has been released in v3.11.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

sergelogvinov pushed a commit to sergelogvinov/terraform-provider-azurerm that referenced this pull request Jul 11, 2022
sergelogvinov pushed a commit to sergelogvinov/terraform-provider-azurerm that referenced this pull request Jul 11, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for the Data Source for azurerm_storage_account to be able to pull the managed identity
3 participants