Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r\linux/windows_virtual_machine: add support for capacity_reservation_group_id #17236

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

myc2h6o
Copy link
Contributor

@myc2h6o myc2h6o commented Jun 14, 2022

Cont. of #16464 to support the Capacity Reservation Group on virtual machine. By specifying the Group ID, the virtual machine will be allocated to the specific Group which has reserved certain VM sizes in advance.

@myc2h6o
Copy link
Contributor Author

myc2h6o commented Jun 14, 2022

Test result:
image

@davidkemper
Copy link

We're really waiting on this to land. The new capacity reservation support won't actually be useful until we can tie it to our vms. As it is now, any time we have to re-create a vm we risk it failing in underprovisioned Azure data centers. This HAS happened to us, and took hours to resolve.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @myc2h6o - LGTM 🦀

@katbyte katbyte merged commit 5697283 into hashicorp:main Jul 6, 2022
@github-actions github-actions bot added this to the v3.13.0 milestone Jul 6, 2022
katbyte added a commit that referenced this pull request Jul 6, 2022
@myc2h6o myc2h6o deleted the vm_cap_res branch July 6, 2022 02:56
@github-actions
Copy link

github-actions bot commented Jul 8, 2022

This functionality has been released in v3.13.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Aug 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants