Add support for no-downtime disk resizes. #17245

kazimierzbudzyk · 2022-06-14T14:06:50Z

Implements #17240.

Enables live disk resizes in all cases where it's supported. Feature flag defaulted to true is left in allowing customers to opt-out if needed.

tombuildsstuff

hey @kazimierzbudzyk

Thanks for this PR - taking a look through here whilst this is off to a good start we need to think about how this should work long-term - since it likely makes sense for this to be enabled by default, I've reached out to the Service Team to get some more details on this Preview feature, which'll determine how we can proceed here.

From our side, I think this makes the most sense to be enabled by default, meaning that this may want to wait for GA - but as mentioned above I've reached out to the Service Team which should allow us to determine how to proceed here.

Thanks!

tombuildsstuff · 2022-06-15T06:15:24Z

internal/services/compute/managed_disk_resource.go

+			"no_downtime_resize_enabled": {
+				Type:     pluginsdk.TypeBool,
+				Optional: true,
+			},


since this is a behavioural feature, this'd need to be added to the features block rather than being enabled against the resource - although I think we actually want to enable this functionality by default where possible once this goes GA - as such I'm not sure this makes sense as a behavioural feature here, where we can instead wait for this to hit GA first and then enable this by default?

We'll also need to update the shutDownOnResize method below to check the disk type too, since this is only supported for Data Disks and not OS Disks

Thanks for the review @tombuildsstuff! Implementing your feedback...

This feature is something my team could use immediately (and likely a lot of other users). If possible starting with it being opt-in while in preview would be super helpful to us, especially if GA will take a bit more. After GA we definitely should flip the default of the feature flag as it will make a lot of operations much easier.

kazimierzbudzyk · 2022-06-15T12:04:40Z

internal/services/compute/managed_disk_resource.go

-func shutDownOnResize(oldSizeGB, newSizeGB int) bool {
+func shutDownOnResize(disk compute.Disk, oldSizeGB, newSizeGB int) bool {
+	// OS disks can't be expanded without downtime.
+	if disk.OsType != "" {


@tombuildsstuff - let me know if you have suggestions for a better way of detecting data disks.

kazimierzbudzyk · 2022-06-27T12:20:27Z

Hi @tombuildsstuff,

Did you hear anything back about the GA timeline for the live-resize feature? Really looking forward to this feature being available in the provider, either as preview feature, or default behaviour post GA. I have it deployed through forked terraform-provider-azurerm to some of my test environments and it works very well.

Thanks,
Kaz

…r-azurerm into kb/live-disk-resize

kazimierzbudzyk · 2022-07-21T21:20:42Z

@tombuildsstuff Looks like the feature was just moved to GA according to https://azure.microsoft.com/en-us/updates/generally-available-live-resize-for-premium-ssd-and-standard-ssd-disk-storage/. I flipped default of the feature flag to true, but keeping the flag to allow users disable as it's a substantial change of behaviour.

internal/services/compute/managed_disk_resource.go

kazimierzbudzyk · 2022-08-03T08:46:52Z

Announcement got pulled back - MicrosoftDocs/azure-docs#96112.

Klaas- · 2022-09-06T06:04:08Z

MicrosoftDocs/azure-docs@b673711 https://azure.microsoft.com/en-us/updates/generally-available-live-resize-for-premium-ssd-and-standard-ssd-disk-storage/

I'd say it's now GA

kazimierzbudzyk · 2022-09-14T20:43:55Z

@tombuildsstuff - with GA re-announcement, is this PR good to be merged now?

Klaas- · 2022-10-10T11:42:21Z

website/docs/guides/features-block.html.markdown

@@ -150,6 +156,12 @@ The `log_analytics_workspace` block supports the following:

 ---

+The `managed_disk` block supports the following:
+
+* `no_downtime_resize` (Optional) Specifies if no-downtime resizes are enabled for the managed disk resources. Defaults to `true`.


maybe use the same name as azure does for this feature enable_live_resize or something like that?

Yeah agreed - digging around this it appears that Expand Without Downtime is the final name for this feature? I'd argue that live_resize_data_disks_where_possible (or something) would be clearer where possible, but since this is only for expanding (and not shrinking, which Azure doesn't support regardless of if the associated VM is online/offline) - I think it's probably worth making this expand_without_downtime for now?

@kazimierzbudzyk

This extends the work done by @kazimierzbudzyk to ensure we check the Virtual Machine and Managed Disk to confirm that they support Expand Without Downtime (and fallback to shutting the machine down if not). Unfortunately we're unable to output a warning either way at this time (since that'd require Framework) - as such this PR includes adding notes to the documentation calling out we'll best-effort this.

tombuildsstuff

hey @kazimierzbudzyk

Apologies for the delayed review here, as mentioned in #17240 we believed that this change needed to be threaded through in a number of places (including the Linux/Windows Virtual Machine, the Linux/Orchestrated/Windows Virtual Machine Scale Set resources and the Data Disk Attachment resource) - however digging into this, this doesn't appear to be the case, so the scope of this change is fine.

Digging into the changes in this PR - whilst on the whole this is looking pretty good we're going to need to make 3 changes to be able to get this merged:

Rename this feature Expand Without Downtime (since that appears to be the GA name for this feature)
Based on the documentation for the Linux Virtual Machine and Windows Virtual Machine resources, we need to check the Virtual Machine that we're attached to to ensure that it supports Expand Without Downtime
Add an acceptance test covering this resource so that we can confirm this actually does Expand Without Downtime without causing a restart of the Virtual Machine.

As such I hope you don't mind but I'm going to push a couple of commits to make those changes so that we can get this merged - once that's done I'll ask @manicminer to take a look and then we should be good to go 👍

Apologies again for the delay reviewing this one, since we believed this change was applicable in a number of resources we wanted to ensure this was behaviourally consistent across the provider - but I think we should be good to go with those changes 👍

Thanks!

tombuildsstuff · 2022-11-07T15:00:39Z

internal/provider/features.go

+			MaxItems: 1,
+			Elem: &pluginsdk.Resource{
+				Schema: map[string]*pluginsdk.Schema{
+					"no_downtime_resize": {


it appears the product name for this has settled on Expand Without Downtime as such we should make this:

Suggested change

"no_downtime_resize": {

"expand_without_downtime": {

tombuildsstuff · 2022-11-07T15:14:41Z

internal/services/compute/managed_disk_resource.go

+func shutDownOnResize(disk *disks.Disk, oldSizeGB, newSizeGB int) bool {
+	// OS disks can't be expanded without downtime.
+	if *disk.Properties.OsType != "" {
+		return true
+	}
+	// Disks smaller than 4 TiB can't be expanded to 4 TiB or larger without downtime.
+	if oldSizeGB < 4096 && newSizeGB >= 4096 {
+		return true
+	}
+	// Only  Premium SSD v1 and Standard SSD disks support live resize
+	for _, diskType := range []disks.DiskStorageAccountTypes{
+		disks.DiskStorageAccountTypesPremiumLRS,
+		disks.DiskStorageAccountTypesPremiumZRS,
+		disks.DiskStorageAccountTypesStandardSSDLRS,
+		disks.DiskStorageAccountTypesStandardSSDZRS,
+	} {
+		if *disk.Sku.Name == diskType {
+			return false
+		}
+	}
+	return true
+}


based on the documentation for both Linux and Windows, we also need to check the VM that we're attached too, including that it supports Expand without Downtime (https://learn.microsoft.com/azure/virtual-machines/linux/expand-disks?tabs=azure-cli%2Cubuntu#expand-without-downtime / https://learn.microsoft.com/azure/virtual-machines/windows/expand-os-disk#expand-without-downtime) - so we'll need to first retrieve the Managed Disk, confirm it's a Virtual Machine, and then retrieve the Virtual Machine to confirm it supports this (else we'll need to fallback as we're doing here)

tombuildsstuff · 2022-11-07T15:17:51Z

website/docs/guides/features-block.html.markdown

@@ -150,6 +156,12 @@ The `log_analytics_workspace` block supports the following:

 ---

+The `managed_disk` block supports the following:
+
+* `no_downtime_resize` (Optional) Specifies if no-downtime resizes are enabled for the managed disk resources. Defaults to `true`.


Yeah agreed - digging around this it appears that Expand Without Downtime is the final name for this feature? I'd argue that live_resize_data_disks_where_possible (or something) would be clearer where possible, but since this is only for expanding (and not shrinking, which Azure doesn't support regardless of if the associated VM is online/offline) - I think it's probably worth making this expand_without_downtime for now?

kazimierzbudzyk · 2022-11-09T14:17:24Z

@tombuildsstuff thanks for the review! Absolutely feel free to take over, really keen to see this released!

Thanks,
Kaz

manicminer

LGTM! 💻

manicminer · 2022-11-09T23:14:50Z

Test results

github-actions · 2022-11-11T01:16:45Z

This functionality has been released in v3.31.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2022-12-11T02:17:11Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

Add support for no-downtime disk resizes.

851699d

github-actions bot added documentation size/XS labels Jun 14, 2022

tombuildsstuff reviewed Jun 15, 2022

View reviewed changes

review: switch to feature from resource argument

a77f38e

github-actions bot added size/M and removed size/XS labels Jun 15, 2022

review: check disk type on resize

1111471

kazimierzbudzyk commented Jun 15, 2022

View reviewed changes

kazimierzbudzyk marked this pull request as ready for review June 15, 2022 12:04

tweak docs

67dda3f

kazimierzbudzyk requested a review from tombuildsstuff June 16, 2022 09:30

kazimierzbudzyk added 3 commits July 21, 2022 22:00

Merge branch 'master' of github.com:kazimierzbudzyk/terraform-provide…

547a7cf

…r-azurerm into kb/live-disk-resize

flip default to true

80e65c3

vendor

fa1d8d0

github-actions bot added the dependencies label Jul 21, 2022

kazimierzbudzyk added 2 commits July 21, 2022 23:20

fix test

d0fe26c

no live resize for Standard HDD

bd50a25

github-actions bot added size/L and removed size/M labels Jul 22, 2022

myc2h6o reviewed Jul 25, 2022

View reviewed changes

internal/services/compute/managed_disk_resource.go Outdated Show resolved Hide resolved

ultra ssd also require restart

87a68d1

update branch

9c37781

github-actions bot removed the dependencies label Sep 14, 2022

invert disk type matching logic to be more explicit

0f3cb84

update branch

bce7ef8

Klaas- reviewed Oct 10, 2022

View reviewed changes

github-actions bot added the waiting-response label Oct 10, 2022

update to use disks package instead of compute

9a7b998

github-actions bot removed the waiting-response label Oct 10, 2022

merge

1b3cc70

tombuildsstuff self-assigned this Oct 17, 2022

kazimierzbudzyk and others added 3 commits October 17, 2022 09:08

Merge branch 'hashicorp:main' into kb/live-disk-resize

6ca8c00

go mod tidy/vendor

db79bfc

tombuildsstuff approved these changes Nov 7, 2022

View reviewed changes

tombuildsstuff mentioned this pull request Nov 7, 2022

Support for disk resize without downtime (live) #17240

Closed

1 task

github-actions bot added dependencies service/monitor size/XL and removed size/L labels Nov 7, 2022

manicminer added 3 commits November 9, 2022 22:01

Merge branch 'main' into kb/live-disk-resize

909ae41

Rename feature flag

4f423ea

goimports

0c8c96a

manicminer approved these changes Nov 9, 2022

View reviewed changes

manicminer merged commit 944993e into hashicorp:main Nov 9, 2022

github-actions bot added this to the v3.31.0 milestone Nov 9, 2022

manicminer added a commit that referenced this pull request Nov 9, 2022

Changelog for #17245

98b0f72

kazimierzbudzyk deleted the kb/live-disk-resize branch November 10, 2022 11:49

github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for no-downtime disk resizes. #17245

Add support for no-downtime disk resizes. #17245

kazimierzbudzyk commented Jun 14, 2022 •

edited

tombuildsstuff left a comment

tombuildsstuff Jun 15, 2022

kazimierzbudzyk Jun 15, 2022

kazimierzbudzyk Jun 15, 2022

kazimierzbudzyk commented Jun 27, 2022

kazimierzbudzyk commented Jul 21, 2022

kazimierzbudzyk commented Aug 3, 2022

Klaas- commented Sep 6, 2022

kazimierzbudzyk commented Sep 14, 2022

Klaas- Oct 10, 2022

tombuildsstuff Nov 7, 2022

tombuildsstuff left a comment

tombuildsstuff Nov 7, 2022

tombuildsstuff Nov 7, 2022

tombuildsstuff Nov 7, 2022

kazimierzbudzyk commented Nov 9, 2022

manicminer left a comment

manicminer commented Nov 9, 2022

github-actions bot commented Nov 11, 2022

github-actions bot commented Dec 11, 2022

Add support for no-downtime disk resizes. #17245

Add support for no-downtime disk resizes. #17245

Conversation

kazimierzbudzyk commented Jun 14, 2022 • edited

tombuildsstuff left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kazimierzbudzyk commented Jun 27, 2022

kazimierzbudzyk commented Jul 21, 2022

kazimierzbudzyk commented Aug 3, 2022

Klaas- commented Sep 6, 2022

kazimierzbudzyk commented Sep 14, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tombuildsstuff left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kazimierzbudzyk commented Nov 9, 2022

manicminer left a comment

Choose a reason for hiding this comment

manicminer commented Nov 9, 2022

github-actions bot commented Nov 11, 2022

github-actions bot commented Dec 11, 2022

kazimierzbudzyk commented Jun 14, 2022 •

edited