Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for no-downtime disk resizes. #17245

Merged
merged 21 commits into from
Nov 9, 2022
Merged

Add support for no-downtime disk resizes. #17245

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
851699d
Add support for no-downtime disk resizes.
kazimierzbudzyk Jun 14, 2022
a77f38e
review: switch to feature from resource argument
kazimierzbudzyk Jun 15, 2022
1111471
review: check disk type on resize
kazimierzbudzyk Jun 15, 2022
67dda3f
tweak docs
kazimierzbudzyk Jun 15, 2022
547a7cf
Merge branch 'master' of github.com:kazimierzbudzyk/terraform-provide…
kazimierzbudzyk Jul 21, 2022
80e65c3
flip default to true
kazimierzbudzyk Jul 21, 2022
fa1d8d0
vendor
kazimierzbudzyk Jul 21, 2022
d0fe26c
fix test
kazimierzbudzyk Jul 21, 2022
bd50a25
no live resize for Standard HDD
kazimierzbudzyk Jul 22, 2022
87a68d1
ultra ssd also require restart
kazimierzbudzyk Jul 26, 2022
9c37781
update branch
kazimierzbudzyk Sep 14, 2022
0f3cb84
invert disk type matching logic to be more explicit
kazimierzbudzyk Sep 14, 2022
bce7ef8
update branch
kazimierzbudzyk Oct 10, 2022
9a7b998
update to use disks package instead of compute
kazimierzbudzyk Oct 10, 2022
1b3cc70
merge
kazimierzbudzyk Oct 14, 2022
6ca8c00
Merge branch 'hashicorp:main' into kb/live-disk-resize
kazimierzbudzyk Oct 17, 2022
87c5510
r/managed_disk: support for Expand Without Downtime
tombuildsstuff Nov 7, 2022
db79bfc
go mod tidy/vendor
tombuildsstuff Nov 7, 2022
909ae41
Merge branch 'main' into kb/live-disk-resize
manicminer Nov 9, 2022
4f423ea
Rename feature flag
manicminer Nov 9, 2022
0c8c96a
goimports
manicminer Nov 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 16 additions & 1 deletion internal/services/compute/managed_disk_resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,11 @@ func resourceManagedDisk() *pluginsdk.Resource {
Optional: true,
},

"no_downtime_resize_enabled": {
Type: pluginsdk.TypeBool,
Optional: true,
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this is a behavioural feature, this'd need to be added to the features block rather than being enabled against the resource - although I think we actually want to enable this functionality by default where possible once this goes GA - as such I'm not sure this makes sense as a behavioural feature here, where we can instead wait for this to hit GA first and then enable this by default?

We'll also need to update the shutDownOnResize method below to check the disk type too, since this is only supported for Data Disks and not OS Disks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review @tombuildsstuff! Implementing your feedback...

This feature is something my team could use immediately (and likely a lot of other users). If possible starting with it being opt-in while in preview would be super helpful to us, especially if GA will take a bit more. After GA we definitely should flip the default of the feature flag as it will make a lot of operations much easier.


"zone": commonschema.ZoneSingleOptionalForceNew(),

"tags": tags.Schema(),
Expand Down Expand Up @@ -652,7 +657,9 @@ func resourceManagedDiskUpdate(d *pluginsdk.ResourceData, meta interface{}) erro

if d.HasChange("disk_size_gb") {
if old, new := d.GetChange("disk_size_gb"); new.(int) > old.(int) {
shouldShutDown = true
if !d.Get("no_downtime_resize_enabled").(bool) || shutDownOnResize(old.(int), new.(int)) {
shouldShutDown = true
}
diskUpdate.DiskUpdateProperties.DiskSizeGB = utils.Int32(int32(new.(int)))
} else {
return fmt.Errorf("- New size must be greater than original size. Shrinking disks is not supported on Azure")
Expand Down Expand Up @@ -977,3 +984,11 @@ func resourceManagedDiskDelete(d *pluginsdk.ResourceData, meta interface{}) erro

return nil
}

func shutDownOnResize(oldSizeGB, newSizeGB int) bool {
// Disks smaller than 4 TiB can't be expanded to 4 TiB or larger without downtime.
if oldSizeGB < 4096 && newSizeGB >= 4096 {
return true
}
return false
}
2 changes: 2 additions & 0 deletions website/docs/r/managed_disk.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,8 @@ The following arguments are supported:

* `on_demand_bursting_enabled` (Optional) Specifies if On-Demand Bursting is enabled for the Managed Disk. Defaults to `false`.

* `no_downtime_resize_enabled` (Optional) Specifies if no-downtime resizes are enabled for the Managed Disk. Feature is currently in public preview and needs to be opted in. More information can be found in [Resize without downtime (preview) documentation](https://docs.microsoft.com/en-us/azure/virtual-machines/linux/expand-disks#resize-without-downtime-preview) Defaults to `false`.

-> **Note:** Credit-Based Bursting is enabled by default on all eligible disks. More information on [Credit-Based and On-Demand Bursting can be found in the documentation](https://docs.microsoft.com/azure/virtual-machines/disk-bursting#disk-level-bursting).

* `tags` - (Optional) A mapping of tags to assign to the resource.
Expand Down