Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

search: refactoring to use go-azure-sdk #17386

Merged
merged 3 commits into from
Jun 28, 2022
Merged

search: refactoring to use go-azure-sdk #17386

merged 3 commits into from
Jun 28, 2022

Conversation

tombuildsstuff
Copy link
Contributor

This PR refactors the search package from using an Embedded SDK to using hashicorp/go-azure-sdk

@tombuildsstuff tombuildsstuff added this to the v3.12.0 milestone Jun 25, 2022
@tombuildsstuff tombuildsstuff requested a review from a team June 25, 2022 05:43
katbyte
katbyte approved these changes Jun 27, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚜

@tombuildsstuff
Copy link
Contributor Author

The merge conflict was in the vendor file/this is the only change in the rebase - merging this so we can also get #17399 in

@tombuildsstuff tombuildsstuff merged commit 02b7f37 into main Jun 28, 2022
@tombuildsstuff tombuildsstuff deleted the r/search-to-go-azure-sdk branch June 28, 2022 19:13
tombuildsstuff added a commit that referenced this pull request Jun 28, 2022
@tombuildsstuff
updating to include #17386
f167246
@github-actions
Copy link

github-actions bot commented Jul 1, 2022

This functionality has been released in v3.12.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Aug 1, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
dependencies refactor service/cognitive-services service/search size/XL
Projects
None yet
Milestone
v3.12.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tombuildsstuff @katbyte