Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_hdinsight_kafka_cluster, azurerm_hdinsight_spark_cluster, azurerm_hdinsight_interactive_query_cluster, azurerm_hdinsight_hbase_cluster, azurerm_hdinsight_hadoop_cluster - add support for compute_isolation block #17449

Merged
merged 3 commits into from
Oct 24, 2022
Merged

azurerm_hdinsight_kafka_cluster, azurerm_hdinsight_spark_cluster, azurerm_hdinsight_interactive_query_cluster, azurerm_hdinsight_hbase_cluster, azurerm_hdinsight_hadoop_cluster - add support for compute_isolation block #17449

merged 3 commits into from
Oct 24, 2022

Conversation

jiaweitao001
Copy link
Contributor

  • Adding compute_isolation_properties block to hdinsight cluster resources.
  • All acc tests passed.

katbyte
katbyte requested changes Aug 9, 2022
View reviewed changes
internal/services/hdinsight/hdinsight_hadoop_cluster_resource.go Outdated
@@ -95,6 +95,8 @@ func resourceHDInsightHadoopCluster() *pluginsdk.Resource {
},
},

"compute_isolation_properties": SchemaHDInsightsComputeIsolation(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

properties is implied and redundant?

Suggested change
"compute_isolation_properties": SchemaHDInsightsComputeIsolation(),
"compute_isolation": SchemaHDInsightsComputeIsolation(),

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will change.

internal/services/hdinsight/schema.go Outdated
MaxItems: 1,
Elem: &pluginsdk.Resource{
Schema: map[string]*schema.Schema{
"enable_compute_isolation": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we put enabled on the end

Suggested change
"enable_compute_isolation": {
"compute_isolation_enabled": {

but at that, as the block is compute isolation shouldn't this just be

Suggested change
"enable_compute_isolation": {
"compute_isolation_enabled": {

otherwise it would be compute_isolation.compute_isolation_enabled ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will make the change.

@jiaweitao001
Copy link
Contributor Author

Hi @katbyte , the attributes are renamed as suggested. Thanks.

katbyte
katbyte approved these changes Aug 30, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM provided test pass 🌳

@jiaweitao001 jiaweitao001 changed the title hdinsight clusters support compute_isolation_properties azurerm_hdinsight_kafka_cluster, azurerm_hdinsight_spark_cluster, azurerm_hdinsight_interactive_query_cluster, azurerm_hdinsight_hbase_cluster, azurerm_hdinsight_hadoop_cluster - add support for compute_isolation_properties property Aug 30, 2022
@katbyte
Copy link
Collaborator

katbyte commented Sep 24, 2022

@jiaweitao001 - can you resolve the merge conflicts so this can be meged?

@tombuildsstuff
Copy link
Contributor

@jiaweitao001 any chance you could rebase this one so that we can get this merged?

@jiaweitao001
Copy link
Contributor Author

Rebased. Thanks.

@katbyte
Copy link
Collaborator

katbyte commented Oct 24, 2022

thanks @jiaweitao001

@katbyte katbyte merged commit 6b80e1d into hashicorp:main Oct 24, 2022
@katbyte katbyte changed the title azurerm_hdinsight_kafka_cluster, azurerm_hdinsight_spark_cluster, azurerm_hdinsight_interactive_query_cluster, azurerm_hdinsight_hbase_cluster, azurerm_hdinsight_hadoop_cluster - add support for compute_isolation_properties property azurerm_hdinsight_kafka_cluster, azurerm_hdinsight_spark_cluster, azurerm_hdinsight_interactive_query_cluster, azurerm_hdinsight_hbase_cluster, azurerm_hdinsight_hadoop_cluster - add support for compute_isolation block Oct 24, 2022
@github-actions github-actions bot added this to the v3.29.0 milestone Oct 24, 2022
katbyte added a commit that referenced this pull request Oct 24, 2022
@katbyte
CHANGELOG #17449
b940691
@github-actions
Copy link

This functionality has been released in v3.29.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation service/hdinsight size/XL
Projects
None yet
Milestone
v3.29.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jiaweitao001 @katbyte @tombuildsstuff