azurerm_cosmosdb_account - primary_sql_connection_string, secondary_sql_connection_string, primary_readonly_sql_connection_string, secondary_readonly_sql_connection_string

[lewis-od]

Add individual connection string attributes to cosmosdb_account resource

Closes #15947

[tombuildsstuff]

hey @lewis-od

Thanks for this PR - taking a look through on the whole this is looking pretty good but I think it could be worth adding sql to the property names since there's different interfaces available to CosmosDB (e.g. SQL / Mongo etc) depending on what's provisioned - WDYT?

Thanks!

[lewis-od]

hey @lewis-od

Thanks for this PR - taking a look through on the whole this is looking pretty good but I think it could be worth adding sql to the property names since there's different interfaces available to CosmosDB (e.g. SQL / Mongo etc) depending on what's provisioned - WDYT?

Thanks!

Hey @tombuildsstuff, thanks for the quick review!

Ah yeah good point - will update as suggested 😊

[katbyte]

Thanks @lewis-od, but i think something odd is going on here as i am seeing a lot of failing tests:

------- Stdout: -------
=== RUN   TestAccCosmosDBAccount_basic_mongo_strong_without_capability
=== PAUSE TestAccCosmosDBAccount_basic_mongo_strong_without_capability
=== CONT  TestAccCosmosDBAccount_basic_mongo_strong_without_capability
    testcase.go:110: Step 1/2 error: Check failed: 1 error occurred:
        	* Check 1/1 error: Check 14/17 error: azurerm_cosmosdb_account.test: Attribute 'primary_connection_string' expected to be set
        
--- FAIL: TestAccCosmosDBAccount_basic_mongo_strong_without_capability (844.62s)
FAIL

[lewis-od]

Thanks @lewis-od, but i think something odd is going on here as i am seeing a lot of failing tests:

------- Stdout: -------
=== RUN   TestAccCosmosDBAccount_basic_mongo_strong_without_capability
=== PAUSE TestAccCosmosDBAccount_basic_mongo_strong_without_capability
=== CONT  TestAccCosmosDBAccount_basic_mongo_strong_without_capability
    testcase.go:110: Step 1/2 error: Check failed: 1 error occurred:
        	* Check 1/1 error: Check 14/17 error: azurerm_cosmosdb_account.test: Attribute 'primary_connection_string' expected to be set
        
--- FAIL: TestAccCosmosDBAccount_basic_mongo_strong_without_capability (844.62s)
FAIL

Ah sorry yeah looks like there's 2 issues:

• The property names that the tests are asserting on are wrong (e.g. primary_connection_string instead of primary_sql_connection_string)
• All of the tests will be expecting the connection string properties to be present, but they won't be set if the kind is MongoDB

Will have a look at fixing these

[lewis-od]

@katbyte okay hopefully those tests should pass now! I've not been able to run all of them, but have ran a couple of both the MongoDB and GlobalDocumentDB varieties and they're working for me

The tflint workflow was failing so I've ran make terrafmt, but it's edited a file I hadn't touched (website/docs/r/kusto_cluster_managed_private_endpoint.html.markdown). Not sure if you want that change in this PR or not?

[katbyte]

Sadly still seeing test failures:

[lewis-od]

Sadly still seeing test failures:

Sorry for the delay in getting back on this. Looks like I hadn't accounted for the legacy Parse kind of Cosmos account. I've made some changes and have ran the TestAccCosmosDBAccount_basic_* tests myself, and all seem to be passing now

[katbyte]

Thanks @lewis-od ! LGTM 🍄

[github-actions]

This functionality has been released in v3.28.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.