Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_*_policy_remediation - should use policy_definition_reference_id in favor of policy_definition_id Fix #18037

Merged
merged 15 commits into from
Sep 15, 2022
Merged

azurerm_*_policy_remediation - should use policy_definition_reference_id in favor of policy_definition_id Fix #18037

merged 15 commits into from
Sep 15, 2022

Conversation

gettek
Copy link
Contributor

@gettek gettek commented Aug 18, 2022 •
edited
Loading

Initiative Remediation tasks should use policy_definition_reference_id in favor of policy_definition_id

Fix #17096
Fix #16454
Fix #17277
Fix gettek/terraform-azurerm-policy-as-code#28

@gettek gettek closed this Aug 18, 2022
@gettek gettek reopened this Aug 18, 2022
@JustinGrote JustinGrote mentioned this pull request Aug 25, 2022
Closed
1 task
@wuxu92
Copy link
Contributor

wuxu92 commented Aug 29, 2022

hi, @gettek thanks for your work and it looks good to me. Just a small tip here, could you please split the updating of the mode property's document to a single PR, so this PR only fixes the policy definition id issue?

@marcelbraak
Copy link

Great job. Cant wait for this PR to be merged.

@gettek
Copy link
Contributor Author

gettek commented Aug 30, 2022 •
edited
Loading

@wuxu92

hi, @gettek thanks for your work and it looks good to me. Just a small tip here, could you please split the updating of the mode property's document to a single PR, so this PR only fixes the policy definition id issue?

#18181

@JustinGrote
Copy link

@wuxu92 got time to review this again? :) It's a blocker for me.

@wuxu92
Copy link
Contributor

wuxu92 commented Sep 7, 2022

we have to wait for Hashicorp's review, @katbyte could you please have a look at this, thanks.

katbyte
katbyte requested changes Sep 9, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gettek - can we please keep the old property and deprecate it letting users know to move to the new one. if you search for features.FourPointOhBeta you can see a number of examples on how to do this.
this way no ones configs are broken and it'll automatically be removed when we release 4.0

thanks!

internal/services/policy/remediation_management_group.go Show resolved Hide resolved
internal/services/policy/remediation_resource.go Show resolved Hide resolved
gettek
gettek commented Sep 13, 2022
View reviewed changes
Copy link
Contributor Author

@gettek gettek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have also removed policy_definition_id from tests, which should be policy_definition_reference_id. This property is only for initiative assignments but these tests only run definition assignments

@corticalstack

This comment was marked as off-topic.

Sign in to view
@gettek gettek requested a review from katbyte September 14, 2022 09:39
@katbyte katbyte changed the title Policy remediation should use definition reference Ids azurerm_*_policy_remediation - should use policy_definition_reference_id in favor of policy_definition_id Fix Sep 15, 2022
katbyte
katbyte approved these changes Sep 15, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gettek - LGTM now! 🌩️

@katbyte katbyte merged commit 37e843f into hashicorp:main Sep 15, 2022
@github-actions github-actions bot added this to the v3.23.0 milestone Sep 15, 2022
katbyte added a commit that referenced this pull request Sep 15, 2022
@katbyte
CHANGELOG #18037
351fe61
@gettek gettek deleted the fix/policy_remediation branch September 15, 2022 19:11
@github-actions
Copy link

This functionality has been released in v3.23.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@gettek gettek mentioned this pull request Sep 21, 2022
Merged
3 tasks
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation service/policy
Projects
None yet
Milestone
v3.23.0
6 participants
@gettek @wuxu92 @marcelbraak @JustinGrote @corticalstack @katbyte