azurerm_batch_pool - support user_accounts, data_disks and etc properties
#18226
Conversation
| nodeAgentSkuID := d.Get("node_agent_sku_id").(string) | ||
|
|
||
| storageImageReferenceSet := d.Get("storage_image_reference").([]interface{}) | ||
| imageReference, err := ExpandBatchPoolImageReference(storageImageReferenceSet) | ||
| if err != nil { | ||
| return fmt.Errorf("creating %s: %+v", id, err) | ||
| } | ||
|
|
||
| if imageReference != nil { | ||
| // if an image reference ID is specified, the user wants use a custom image. This property is mutually exclusive with other properties. | ||
| if imageReference.ID != nil && (imageReference.Offer != nil || imageReference.Publisher != nil || imageReference.Sku != nil || imageReference.Version != nil) { | ||
| return fmt.Errorf("creating %s: Properties version, offer, publish cannot be defined when using a custom image id", id) | ||
| } else if imageReference.ID == nil && (imageReference.Offer == nil || imageReference.Publisher == nil || imageReference.Sku == nil || imageReference.Version == nil) { | ||
| return fmt.Errorf("creating %s: Properties version, offer, publish and sku are mandatory when not using a custom image", id) | ||
| } | ||
| } else { | ||
| return fmt.Errorf("creating %s: image reference property can not be empty", id) | ||
| } | ||
|
|
There was a problem hiding this comment.
This check logic is moved to expandBatchPoolVirtualMachineConfiguration in batch_pool.go
liuwuliuyun
changed the title
azurerm_batch_pool - support user_accounts, data_disks and etc propertiesazurerm_batch_pool - support user_accounts, data_disks and etc properties
|
|
|
This PR also fixes #18267 |
Co-authored-by: kt <kt@katbyte.me>
|
Thanks @katbyte for your review and feedbacks, here is the test result on the latest comments: |
|
This functionality has been released in v3.23.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
azurerm_batch_poolsupport following new properties/property blocks:data_disksdisk_encryption_configurationextensionsinter_node_communicationlicense_typenode_placement_configurationos_disk_placement_settingwindows_configurationuser_accountstask_scheduling_policyfixes #18267