Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Source: azurerm_storage_account - support for the azure_files_identity_based_auth property #18405

Merged
merged 3 commits into from
Sep 21, 2022

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Sep 16, 2022

Fix #18372

Test

💤  TF_ACC=1 go test -v -timeout=20h ./internal/services/storage -run='TestAccDataSourceStorageAccount_azureFilesAuthentication'
=== RUN   TestAccDataSourceStorageAccount_azureFilesAuthentication
=== PAUSE TestAccDataSourceStorageAccount_azureFilesAuthentication
=== CONT  TestAccDataSourceStorageAccount_azureFilesAuthentication
--- PASS: TestAccDataSourceStorageAccount_azureFilesAuthentication (99.07s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/storage       99.081s

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚙️

@katbyte katbyte merged commit 869e4f1 into hashicorp:main Sep 21, 2022
@github-actions github-actions bot added this to the v3.24.0 milestone Sep 21, 2022
katbyte added a commit that referenced this pull request Sep 21, 2022
@github-actions
Copy link

This functionality has been released in v3.24.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for storage-account Data source to return ActiveDirectory properties
2 participants