Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_sentinel_alert_rule_scheduled - support for the techniques property #18430

Merged
merged 3 commits into from
Sep 21, 2022

Conversation

ziyeqf
Copy link
Contributor

@ziyeqf ziyeqf commented Sep 19, 2022

fix #16265

Test

 TF_ACC=1 go test -v ./internal/services/sentinel -run=TestAccSentinelAlertRuleScheduled -timeout=60m        
=== RUN   TestAccSentinelAlertRuleScheduled_basic
=== PAUSE TestAccSentinelAlertRuleScheduled_basic
=== RUN   TestAccSentinelAlertRuleScheduled_complete
=== PAUSE TestAccSentinelAlertRuleScheduled_complete
=== RUN   TestAccSentinelAlertRuleScheduled_update
=== PAUSE TestAccSentinelAlertRuleScheduled_update
=== RUN   TestAccSentinelAlertRuleScheduled_requiresImport
=== PAUSE TestAccSentinelAlertRuleScheduled_requiresImport
=== RUN   TestAccSentinelAlertRuleScheduled_withAlertRuleTemplateGuid
=== PAUSE TestAccSentinelAlertRuleScheduled_withAlertRuleTemplateGuid
=== RUN   TestAccSentinelAlertRuleScheduled_updateEventGroupingSetting
=== PAUSE TestAccSentinelAlertRuleScheduled_updateEventGroupingSetting
=== CONT  TestAccSentinelAlertRuleScheduled_basic
=== CONT  TestAccSentinelAlertRuleScheduled_requiresImport
=== CONT  TestAccSentinelAlertRuleScheduled_updateEventGroupingSetting
=== CONT  TestAccSentinelAlertRuleScheduled_withAlertRuleTemplateGuid
=== CONT  TestAccSentinelAlertRuleScheduled_update
=== CONT  TestAccSentinelAlertRuleScheduled_complete
--- PASS: TestAccSentinelAlertRuleScheduled_basic (198.77s)
--- PASS: TestAccSentinelAlertRuleScheduled_requiresImport (239.06s)
--- PASS: TestAccSentinelAlertRuleScheduled_complete (245.99s)
--- PASS: TestAccSentinelAlertRuleScheduled_withAlertRuleTemplateGuid (264.16s)
--- PASS: TestAccSentinelAlertRuleScheduled_updateEventGroupingSetting (358.40s)
--- PASS: TestAccSentinelAlertRuleScheduled_update (419.89s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/sentinel      421.011s

@ziyeqf ziyeqf marked this pull request as ready for review September 19, 2022 06:35
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌩️

@katbyte katbyte merged commit e70cf03 into hashicorp:main Sep 21, 2022
@github-actions github-actions bot added this to the v3.24.0 milestone Sep 21, 2022
katbyte added a commit that referenced this pull request Sep 21, 2022
@github-actions
Copy link

This functionality has been released in v3.24.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@ziyeqf ziyeqf deleted the tengzh/sentinel/alertrule_techniques branch September 26, 2022 13:00
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants