Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_virtual_hub_bgp_connection - support for virtual_network_connection_id property #18469

Merged

Conversation

sinbai
Copy link
Contributor

@sinbai sinbai commented Sep 21, 2022

fix #17872.

Test result:
image

@sinbai sinbai force-pushed the network/support_virtual_network_connection_id branch from 691af51 to ddbc78f Compare September 21, 2022 06:28
@sinbai sinbai changed the title Test Fix PR [WIP] azurerm_virtual_hub_bgp_connection - support for virtual_network_connection_id property azurerm_virtual_hub_bgp_connection - support for virtual_network_connection_id property Sep 21, 2022
@khabbabs

This comment was marked as off-topic.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good aside from a test failure:

image

@sinbai
Copy link
Contributor Author

sinbai commented Sep 23, 2022

looks good aside from a test failure:

image

@katbyte fixed.
image

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🧮

@katbyte katbyte merged commit c43ff99 into hashicorp:main Sep 27, 2022
@github-actions github-actions bot added this to the v3.25.0 milestone Sep 27, 2022
katbyte added a commit that referenced this pull request Sep 27, 2022
katbyte added a commit that referenced this pull request Sep 27, 2022
@github-actions
Copy link

This functionality has been released in v3.25.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2022
@sinbai sinbai deleted the network/support_virtual_network_connection_id branch March 28, 2024 03:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_virtual_hub_bgp_connection fails and expects existing provisioned HubVirtualNetworkConnection
3 participants