Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_stream_analytics_output_servicebus_queue: add support for authentication_mode #18491

Merged
merged 2 commits into from
Oct 12, 2022
Merged

azurerm_stream_analytics_output_servicebus_queue: add support for authentication_mode #18491

merged 2 commits into from
Oct 12, 2022

Conversation

jiaweitao001
Copy link
Contributor

  • Test result:
--- PASS: TestAccStreamAnalyticsOutputServiceBusQueue_authenticationMode (407.17s)
PASS

katbyte
katbyte requested changes Sep 22, 2022
View reviewed changes
internal/services/streamanalytics/stream_analytics_output_servicebus_queue_resource_test.go
`, template, data.RandomInteger)
}

func (r StreamAnalyticsOutputServiceBusQueueResource) template(data acceptance.TestData, identity string) string {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

identity is unused in this function?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's used on L435.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

life 435 doesn't exist in this function?
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, misunderstood previously. Added identity usage in template now.

@jiaweitao001 jiaweitao001 force-pushed the stream_analytics_servicebus_queue branch from 876c65b to c201fa3 Compare October 8, 2022 05:55
katbyte
katbyte approved these changes Oct 12, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍖

@katbyte katbyte merged commit d0dd0b2 into hashicorp:main Oct 12, 2022
@github-actions github-actions bot added this to the v3.27.0 milestone Oct 12, 2022
katbyte added a commit that referenced this pull request Oct 12, 2022
@katbyte
CHANGELOG #18491
2f05e74
@jiaweitao001 jiaweitao001 deleted the stream_analytics_servicebus_queue branch October 13, 2022 02:48
@github-actions
Copy link

This functionality has been released in v3.27.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation service/stream-analytics
Projects
None yet
Milestone
v3.27.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jiaweitao001 @katbyte