Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_mssql_server_transparent_data_encryption - Support for autorotation of KV keys #18523

Merged
merged 8 commits into from
Oct 26, 2022
Merged

azurerm_mssql_server_transparent_data_encryption - Support for autorotation of KV keys #18523

merged 8 commits into from
Oct 26, 2022

Conversation

aristosvo
Copy link
Collaborator

@aristosvo aristosvo commented Sep 25, 2022 •
edited
Loading

Fixes #14171

  • Docs updated

Acceptance tests:

image

@github-actions github-actions bot added the service/mssql Microsoft SQL Server label Sep 25, 2022
tombuildsstuff
tombuildsstuff approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question from me around the default value (since we're getting the boolean default value false via d.Get and defaulting this to false in the Read function) - but this otherwise LGTM 👍

internal/services/mssql/mssql_server_transparent_data_encryption_resource.go Outdated Show resolved Hide resolved
@katbyte katbyte merged commit b017646 into hashicorp:main Oct 26, 2022
@github-actions github-actions bot added this to the v3.29.0 milestone Oct 26, 2022
katbyte added a commit that referenced this pull request Oct 26, 2022
@katbyte
CHANGELOG #18523
aafd4b5
@github-actions
Copy link

This functionality has been released in v3.29.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@dkuzmenok dkuzmenok mentioned this pull request Nov 7, 2022
Merged
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
documentation enhancement service/mssql Microsoft SQL Server
Projects
None yet
Milestone
v3.29.0
Development

Successfully merging this pull request may close these issues.

Support for auto rotate key in azurerm_mssql_server_transparent_data_encryption
3 participants
@aristosvo @tombuildsstuff @katbyte