Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_disk_pool azurerm_disk_pool_iscsi_target azurerm_disk_pool_iscsi_target_lun azurerm_disk_pool_managed_disk_attachment - Remove registration for Microsoft.StoragePool and add deprecation message for affected resources #18905

Merged
merged 2 commits into from Oct 24, 2022

Conversation

lonegunmanb
Copy link
Contributor

@lonegunmanb lonegunmanb commented Oct 21, 2022

As #18820 pointed out, all new subscriptions will meet issue on plugin's startup because Azure has halted the preview of Azure Disk Pools. The subscriptions which have registered Microsoft.StoragePool can still call the registration API and use disk pool API, and new subscriptions need an explicit skip_provider_registration to skip this registration.

This pr removed Microsoft.StoragePool from the required resource provider list to avoid such error so the new subscriptions don't need this skip_provider_registration anymore.

@lonegunmanb lonegunmanb force-pushed the remove-registration-storagepool branch from eaaebd3 to 6854cd4 Compare October 24, 2022 06:41
@lonegunmanb lonegunmanb changed the title azurerm_disk_pool azurerm_disk_pool_iscsi_target azurerm_disk_pool_iscsi_target_lun azurerm_disk_pool_managed_disk_attachment - Remove registration for Microsoft.StoragePool azurerm_disk_pool azurerm_disk_pool_iscsi_target azurerm_disk_pool_iscsi_target_lun azurerm_disk_pool_managed_disk_attachment - Remove registration for Microsoft.StoragePool and add deprecation message for affected resources Oct 24, 2022
@lonegunmanb
Copy link
Contributor Author

Hi, as @tombuildsstuff kindly suggested, I've add deprecation message to those resources, and remove registration for Microsoft.StoragePool, would you please give this pr a review @stephybun @tombuildsstuff ? Thanks!

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎱

@katbyte katbyte closed this Oct 24, 2022
@katbyte katbyte reopened this Oct 24, 2022
@katbyte katbyte merged commit 9c52c39 into hashicorp:main Oct 24, 2022
@github-actions github-actions bot added this to the v3.29.0 milestone Oct 24, 2022
katbyte added a commit that referenced this pull request Oct 24, 2022
@github-actions
Copy link

This functionality has been released in v3.29.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants