Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_monitor_scheduled_query_rules_alert_v2 - add evaluation_frequency, window_duration, mute_actions_after_alert_duration, and query_time_range_overridevalidation and doc #18960

Conversation

teowa
Copy link
Contributor

@teowa teowa commented Oct 25, 2022

Resolves #18895

related to Azure/azure-rest-api-specs#21258, actually the service API has more strict limitation than just ISO 8601 to those propties.

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jackofallops
Copy link
Member

Tests look good:
image

@jackofallops jackofallops merged commit 78febf8 into hashicorp:main Oct 25, 2022
@github-actions github-actions bot added this to the v3.29.0 milestone Oct 25, 2022
jackofallops added a commit that referenced this pull request Oct 25, 2022
@github-actions
Copy link

This functionality has been released in v3.29.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validation at planning stage for duration on azurerm_monitor_scheduled_query_rules_alert_v2
2 participants