Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appconfiguration/sdk: Fix pagination logic #19020

Merged
merged 5 commits into from
Oct 27, 2022

Conversation

favoretti
Copy link
Collaborator

@favoretti favoretti commented Oct 27, 2022

Append endpoint URL to autorest preparer, since API apparently doesn't return it itself.
Introducing fix as a hack for now following internal discussions.

Fixes #19002

Append endpoint URL to autorest preparer, since API apparently doesn't
return it itself.

Fixes hashicorp#19002
Copy link
Member

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @favoretti, this LGTM! 👍

@manicminer manicminer added this to the v3.29.0 milestone Oct 27, 2022
@manicminer manicminer added the bug label Oct 27, 2022
@favoretti
Copy link
Collaborator Author

image

@katbyte katbyte merged commit 7d9def5 into hashicorp:main Oct 27, 2022
katbyte added a commit that referenced this pull request Oct 27, 2022
@github-actions
Copy link

This functionality has been released in v3.29.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data azurerm_app_configuration_keys fails with large number of keys
3 participants