Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource azurerm_network_manager #19334

Merged
merged 2 commits into from
Dec 7, 2022

Conversation

teowa
Copy link
Contributor

@teowa teowa commented Nov 17, 2022

Notes

Coming Resources:

  1. Network Managers New Resource azurerm_network_manager #19334 /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkManagers/{networkManagerName}
  2. Network Groups New Resource: azurerm_network_manager_network_group #19593 /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkManagers/{networkManagerName}/networkGroups/{networkGroupName}
  3. Static Members /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkManagers/{networkManagerName}/networkGroups/{networkGroupName}/staticMembers/{staticMemberName}
  4. Connectivity Configurations /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkManagers/{networkManagerName}/connectivityConfigurations/{configurationName}
  5. Security Admin Configurations /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkManagers/{networkManagerName}/securityAdminConfigurations
  6. Admin Rule Collections /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkManagers/{networkManagerName}/securityAdminConfigurations/{configurationName}/ruleCollections/{ruleCollectionName}
  7. Admin Rules /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkManagers/{networkManagerName}/securityAdminConfigurations/{configurationName}/ruleCollections/{ruleCollectionName}/rules/{ruleName}
  8. Network Manager Connections
    /subscriptions/{subscriptionId}/providers/Microsoft.Network/networkManagerConnections/{networkManagerConnectionName} New Resource azurerm_network_manager_subscription_connection #19617
    /providers/Microsoft.Management/managementGroups/{managementGroupId}/providers/Microsoft.Network/networkManagerConnections/{networkManagerConnectionName} New Resource azurerm_network_manager_management_group_connection #19621
  9. Scope Connections New Resource azurerm_network_manager_scope_connection #19610 /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkManagers/{networkManagerName}/scopeConnections/{scopeConnectionName}
  10. Network Manager Commit /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Network/networkManagers/{networkManagerName}/commit

Test:

TF_ACC=1 go test -v ./internal/services/network -parallel 20 -test.run=TestAccNetworkManager$ -timeout 1440m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccNetworkManager
=== RUN   TestAccNetworkManager/Manager
=== RUN   TestAccNetworkManager/Manager/basic
=== RUN   TestAccNetworkManager/Manager/complete
=== RUN   TestAccNetworkManager/Manager/update
=== RUN   TestAccNetworkManager/Manager/requiresImport
--- PASS: TestAccNetworkManager (1145.03s)
    --- PASS: TestAccNetworkManager/Manager (1145.03s)
        --- PASS: TestAccNetworkManager/Manager/basic (229.55s)
        --- PASS: TestAccNetworkManager/Manager/complete (227.58s)
        --- PASS: TestAccNetworkManager/Manager/update (434.87s)
        --- PASS: TestAccNetworkManager/Manager/requiresImport (253.03s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/network       1145.063s

@teowa teowa changed the title New Resource azurerm_network manager New Resource azurerm_network_manager Nov 18, 2022
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌩️

@katbyte katbyte merged commit 97499a7 into hashicorp:main Dec 7, 2022
@github-actions github-actions bot added this to the v3.35.0 milestone Dec 7, 2022
katbyte added a commit that referenced this pull request Dec 7, 2022
@github-actions
Copy link

github-actions bot commented Dec 9, 2022

This functionality has been released in v3.35.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jan 9, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants