Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix - azurerm_virtual_desktop_workspace_application_group_association- Association should not remove the tags #19574

Merged
merged 2 commits into from
Dec 6, 2022

Conversation

xuzhang3
Copy link
Contributor

@xuzhang3 xuzhang3 commented Dec 6, 2022

Fixes: #18677
Association update should not remove the workspace tags.

@xuzhang3 xuzhang3 changed the title Bug Fix - azurerm_virtual_desktop_workspace_application_group_association update should not remove the tags Bug Fix - azurerm_virtual_desktop_workspace_application_group_association- Association should not remove the tags Dec 6, 2022
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests didn't pick this up, so can we update a test to set the tags?

@xuzhang3
Copy link
Contributor Author

xuzhang3 commented Dec 6, 2022

@stephybun test cases updated.
AccTests:

=== RUN   TestAccVirtualDesktopWorkspaceApplicationGroupAssociation_basic
=== PAUSE TestAccVirtualDesktopWorkspaceApplicationGroupAssociation_basic
=== RUN   TestAccVirtualDesktopWorkspaceApplicationGroupAssociation_complete
=== PAUSE TestAccVirtualDesktopWorkspaceApplicationGroupAssociation_complete
=== RUN   TestAccVirtualDesktopWorkspaceApplicationGroupAssociation_update
=== PAUSE TestAccVirtualDesktopWorkspaceApplicationGroupAssociation_update
=== RUN   TestAccVirtualDesktopWorkspaceApplicationGroupAssociation_requiresImport
=== PAUSE TestAccVirtualDesktopWorkspaceApplicationGroupAssociation_requiresImport
=== CONT  TestAccVirtualDesktopWorkspaceApplicationGroupAssociation_basic
=== CONT  TestAccVirtualDesktopWorkspaceApplicationGroupAssociation_requiresImport
=== CONT  TestAccVirtualDesktopWorkspaceApplicationGroupAssociation_update
=== CONT  TestAccVirtualDesktopWorkspaceApplicationGroupAssociation_complete
--- PASS: TestAccVirtualDesktopWorkspaceApplicationGroupAssociation_basic (273.43s)
--- PASS: TestAccVirtualDesktopWorkspaceApplicationGroupAssociation_complete (283.12s)
--- PASS: TestAccVirtualDesktopWorkspaceApplicationGroupAssociation_requiresImport (313.96s)
--- PASS: TestAccVirtualDesktopWorkspaceApplicationGroupAssociation_update (512.66s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/desktopvirtualization 568.500s

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xuzhang3 LGTM 👍

@stephybun stephybun added the bug label Dec 6, 2022
@stephybun stephybun merged commit c9645b8 into hashicorp:main Dec 6, 2022
@github-actions github-actions bot added this to the v3.35.0 milestone Dec 6, 2022
stephybun added a commit that referenced this pull request Dec 6, 2022
@github-actions
Copy link

github-actions bot commented Dec 9, 2022

This functionality has been released in v3.35.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jan 9, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_virtual_desktop_workspace not applying tags on first apply
2 participants