Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Fix - azurerm_virtual_desktop_workspace_application_group_association- Association should not remove the tags #19574

Merged
merged 2 commits into from
Dec 6, 2022
Merged

Bug Fix - azurerm_virtual_desktop_workspace_application_group_association- Association should not remove the tags #19574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
869696e
fix issue 18677, update should not remove the tags
Dec 6, 2022
36a84e5
update test cases
Dec 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...desktopvirtualization/virtual_desktop_workspace_application_group_association_resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ func resourceVirtualDesktopWorkspaceApplicationGroupAssociationCreate(d *plugins
Properties: &workspace.WorkspacePatchProperties{
ApplicationGroupReferences: &applicationGroupAssociations,
},
Tags: model.Tags,
}
if _, err = client.Update(ctx, *workspaceId, payload); err != nil {
return fmt.Errorf("creating association between %s and %s: %+v", *workspaceId, *applicationGroupId, err)
Expand Down Expand Up @@ -200,6 +201,7 @@ func resourceVirtualDesktopWorkspaceApplicationGroupAssociationDelete(d *plugins
Properties: &workspace.WorkspacePatchProperties{
ApplicationGroupReferences: &applicationGroupReferences,
},
Tags: model.Tags,
}
if _, err = client.Update(ctx, id.Workspace, payload); err != nil {
return fmt.Errorf("removing association between %s and %s: %+v", id.Workspace, id.ApplicationGroup, err)
Expand Down
6 changes: 6 additions & 0 deletions ...opvirtualization/virtual_desktop_workspace_application_group_association_resource_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,9 @@ resource "azurerm_virtual_desktop_workspace" "test" {
name = "acctestWS%d"
location = azurerm_resource_group.test.location
resource_group_name = azurerm_resource_group.test.name
tags = {
environment = "test"
}
}

resource "azurerm_virtual_desktop_host_pool" "test" {
Expand Down Expand Up @@ -168,6 +171,9 @@ resource "azurerm_virtual_desktop_workspace" "test" {
name = "acctestWS%d"
location = azurerm_resource_group.test.location
resource_group_name = azurerm_resource_group.test.name
tags = {
environment = "test"
}
}

resource "azurerm_virtual_desktop_host_pool" "test" {
Expand Down