Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_key_vault_managed_hardware_security_module: support for public_network_access_enabled and network_acls properties #19640

Merged
merged 2 commits into from
Dec 12, 2022
Merged

azurerm_key_vault_managed_hardware_security_module: support for public_network_access_enabled and network_acls properties #19640

merged 2 commits into from
Dec 12, 2022

Conversation

wuxu92
Copy link
Contributor

@wuxu92 wuxu92 commented Dec 10, 2022 •
edited
Loading 

=== RUN   TestAccKeyVaultManagedHardwareSecurityModule
--- PASS: TestAccKeyVaultManagedHardwareSecurityModule (5817.81s)
=== RUN   TestAccKeyVaultManagedHardwareSecurityModule/data_source
    --- PASS: TestAccKeyVaultManagedHardwareSecurityModule/data_source (1450.50s)
=== RUN   TestAccKeyVaultManagedHardwareSecurityModule/data_source/basic
        --- PASS: TestAccKeyVaultManagedHardwareSecurityModule/data_source/basic (1450.50s)
=== RUN   TestAccKeyVaultManagedHardwareSecurityModule/resource
    --- PASS: TestAccKeyVaultManagedHardwareSecurityModule/resource (4367.30s)
=== RUN   TestAccKeyVaultManagedHardwareSecurityModule/resource/basic
        --- PASS: TestAccKeyVaultManagedHardwareSecurityModule/resource/basic (1514.99s)
=== RUN   TestAccKeyVaultManagedHardwareSecurityModule/resource/update
        --- PASS: TestAccKeyVaultManagedHardwareSecurityModule/resource/update (1453.90s)
=== RUN   TestAccKeyVaultManagedHardwareSecurityModule/resource/complete
        --- PASS: TestAccKeyVaultManagedHardwareSecurityModule/resource/complete (1398.41s)
PASS

image

katbyte
katbyte approved these changes Dec 12, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔐

@katbyte katbyte merged commit 351b0a6 into hashicorp:main Dec 12, 2022
katbyte added a commit that referenced this pull request Dec 12, 2022
@katbyte
CHANGELOG #19640
977f49b
@wuxu92 wuxu92 deleted the mhsm/vangrd branch January 10, 2023 07:25
favoretti pushed a commit to favoretti/terraform-provider-azurerm that referenced this pull request Jan 12, 2023
@wuxu92 @favoretti
azurerm_key_vault_managed_hardware_security_module: support for `pu…
dea15cb 
…blic_network_access_enabled` and `network_acls` properties (hashicorp#19640)
favoretti pushed a commit to favoretti/terraform-provider-azurerm that referenced this pull request Jan 12, 2023
@katbyte @favoretti
CHANGELOG hashicorp#19640
f1b7206
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation service/key-vault Key Vault size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wuxu92 @katbyte