azurerm_proximity_placement_group - fix update when vm is attached
#20131
Conversation
|
Test result |
| @@ -57,7 +56,7 @@ func resourceProximityPlacementGroup() *pluginsdk.Resource { | |||
| MinItems: 1, | |||
| Elem: &pluginsdk.Schema{ | |||
| Type: pluginsdk.TypeString, | |||
| ValidateFunc: validation.StringInSlice(virtualmachines.PossibleValuesForVirtualMachineSizeTypes(), false), | |||
| ValidateFunc: validation.StringIsNotEmpty, | |||
There was a problem hiding this comment.
We can't really do this here, whilst it may be lagging behind the swagger updates, not validating the values invites a lot of other problems. Is there a reason there's a lag between the swagger updates and the service updates?
There was a problem hiding this comment.
This string slice only populates value for HardwareProfile.vmSize but not the full list of VM Sizes, thus some of the possible values are not contained there. It is currently not applicable to get a static full list, so updating it to the same validation as in VM
There was a problem hiding this comment.
does that not indicate that the swagger is incomplete and needs these missing values added?
There was a problem hiding this comment.
It seems like the service is moving away from the static enum list, so the list is incomplete any more. It is said in the swagger that "The enum data type is currently deprecated and will be removed by December 23rd 2023.".
There was a problem hiding this comment.
ahh then that would explain why it is not maintained. there isn't much we can do about it then. thanks @myc2h6o
|
Hi @katbyte thanks for reviewing! I've resolved the conflicts |
|
still have conflicts @myc2h6o |
|
@katbyte have resolved the second conflicts |
|
This functionality has been released in v3.46.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Fix #20056
allowed_vm_sizes, as VM sizes could be added ahead of Spec update, and it is validated at service sideallowed_vm_sizesto empty, only explicitly set it to empty when existing property value is not empty. When existing property value is empty, explicitly setting it to empty will cause failure when there is a VM attached to it.