Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource - azurerm_iothub_file_upload #20668

Merged
merged 3 commits into from
May 24, 2023

Conversation

myc2h6o
Copy link
Contributor

@myc2h6o myc2h6o commented Feb 27, 2023

Close #20074
Extracting file_upload from azurerm_iothub

A `file_upload` block supports the following:

This could resolve this restriction as well

@tombuildsstuff
Copy link
Contributor

@myc2h6o the limitation mentioned above ~> **NOTE:** An IoT Hub can only be updated to use the System-Assigned Managed Identity for file_upload since it is not possible to grant access to the endpoint until after creation. can be worked around within that resource by having the Create method call the Update method - so I'm not sure why we're pushing that limitation onto end-users?

@myc2h6o
Copy link
Contributor Author

myc2h6o commented Feb 27, 2023

Hi @tombuildsstuff thanks for reviewing! For the limitation, it involves two resources: both the azurerm_iothub and the azurerm_role_assignment thus not able to workaorunding it in the iothub resource itself. We need to create the iothub with SystemAssigned identity first, then create a role_assignment to assign the Storage related role to the identity, and only after that can we update the iothub to set the file_upload to use the SystemAssigned identity.

@myc2h6o
Copy link
Contributor Author

myc2h6o commented Feb 27, 2023

Test result
image

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 📡

@katbyte katbyte merged commit 518b659 into hashicorp:main May 24, 2023
1 check passed
katbyte added a commit that referenced this pull request May 24, 2023
@github-actions github-actions bot added this to the v3.58.0 milestone May 24, 2023
@myc2h6o myc2h6o deleted the iothub_file_upload branch May 25, 2023 03:31
@github-actions
Copy link

This functionality has been released in v3.58.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for azurerm_iothub file_upload as an individal resource
3 participants