Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: azurerm_security_center_workspace #2072

Merged
merged 7 commits into from Oct 14, 2018
Merged

New Resource: azurerm_security_center_workspace #2072

merged 7 commits into from Oct 14, 2018

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Oct 13, 2018

No description provided.

@katbyte katbyte added this to the 1.17.0 milestone Oct 13, 2018
@ghost ghost added the size/XXL label Oct 13, 2018
@katbyte
Copy link
Collaborator Author

katbyte commented Oct 13, 2018

#2043 and #2045 should be merged first

tombuildsstuff
tombuildsstuff approved these changes Oct 13, 2018
View reviewed changes
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few minor comments but this otherwise LGTM 👍

azurerm/resource_arm_security_center_workspace.go Outdated

//only valid name is default
// Message="Invalid workspace settings name 'kttest' , only default is allowed "
const resourceArmSecurityCenterWorkspaceName = "default"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we ditch resourceArm from the start of this?

website/docs/r/security_center_workspace.markdown

The following arguments are supported:

* `scope` - (Required) The scope of VMs to send their security data to the desired workspace, unless overridden by a setting with more specific scope.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this just VM's, or is this Resources?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API docs specifically said VMs

website/docs/r/security_center_workspace.markdown Outdated
The contact can be imported using the `resource id`, e.g.

```shell
terraform import azurerm_securitycenter_workspace.example /subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Security/securityWorkspaces/default
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

securitycenter -> security_center

@ghost ghost added size/XL and removed size/XXL labels Oct 13, 2018
@katbyte
Copy link
Collaborator Author

katbyte commented Oct 14, 2018 •
edited

Tests pass:

gofmt -w $(find . -name '*.go' |grep -v vendor)
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./azurerm -v -test.run=TestAccAzureRMSecurityCenter -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMSecurityCenterContact_basic
--- PASS: TestAccAzureRMSecurityCenterContact_basic (18.72s)
=== RUN   TestAccAzureRMSecurityCenterContact_update
--- PASS: TestAccAzureRMSecurityCenterContact_update (47.60s)
=== RUN   TestAccAzureRMSecurityCenter_pricingAndWorkspace
=== RUN   TestAccAzureRMSecurityCenter_pricingAndWorkspace/workspace
=== RUN   TestAccAzureRMSecurityCenter_pricingAndWorkspace/workspace/basic
=== RUN   TestAccAzureRMSecurityCenter_pricingAndWorkspace/workspace/update
=== RUN   TestAccAzureRMSecurityCenter_pricingAndWorkspace/pricing
=== RUN   TestAccAzureRMSecurityCenter_pricingAndWorkspace/pricing/update
--- PASS: TestAccAzureRMSecurityCenter_pricingAndWorkspace (1597.64s)
    --- PASS: TestAccAzureRMSecurityCenter_pricingAndWorkspace/workspace (1545.37s)
        --- PASS: TestAccAzureRMSecurityCenter_pricingAndWorkspace/workspace/basic (173.71s)
        --- PASS: TestAccAzureRMSecurityCenter_pricingAndWorkspace/workspace/update (1371.66s)
    --- PASS: TestAccAzureRMSecurityCenter_pricingAndWorkspace/pricing (52.26s)
        --- PASS: TestAccAzureRMSecurityCenter_pricingAndWorkspace/pricing/update (52.26s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	1663.993s

@katbyte katbyte merged commit ca6c3a1 into master Oct 14, 2018
@katbyte katbyte deleted the r-security-workspace branch October 14, 2018 03:55
@katbyte katbyte changed the title New Resource: azurerm_securitycenter_workspace New Resource: azurerm_security_center_workspace Oct 14, 2018
katbyte added a commit that referenced this pull request Oct 14, 2018
@katbyte
Update CHANGELOG.md to include #2072
6ed8129
@ghost
Copy link

ghost commented Mar 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
new-resource service/security-center size/XL
Projects
None yet
Milestone
v1.17.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@katbyte @tombuildsstuff