Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource:azurerm_mobile_network_sim_policy;New Datasource: azurerm_mobile_network_sim_policy #20732

Merged
merged 3 commits into from
Mar 14, 2023

Conversation

ziyeqf
Copy link
Contributor

@ziyeqf ziyeqf commented Mar 2, 2023

overall

order | name 
0     | azurerm_mobile_network                              ✅
1     | azurerm_mobile_network_site                         ✅
1     | azurerm_mobile_network_data_network                 ✅
1     | azurerm_mobile_network_service                      ✅
1     | azurerm_mobile_network_slice                        ✅
1     | azurerm_mobile_network_sim_group                    ✅
2     | azurerm_mobile_network_packet_core_control_plane    #20730
2     | azurerm_mobile_network_sim_policy                   <- this one
3     | azurerm_mobile_network_packet_core_data_plane       
4     | azurerm_mobile_network_attached_data_network        
5     | azurerm_mobile_network_sim        

test

terraform-provider-azurerm ❯ TF_ACC=1 go test -v ./internal/services/mobilenetwork -run=TestAccMobileNetworkSimPolicy -timeout=600m
=== RUN   TestAccMobileNetworkSimPolicyDataSource_complete
=== PAUSE TestAccMobileNetworkSimPolicyDataSource_complete
=== RUN   TestAccMobileNetworkSimPolicy_basic
=== PAUSE TestAccMobileNetworkSimPolicy_basic
=== RUN   TestAccMobileNetworkSimPolicy_requiresImport
=== PAUSE TestAccMobileNetworkSimPolicy_requiresImport
=== RUN   TestAccMobileNetworkSimPolicy_complete
=== PAUSE TestAccMobileNetworkSimPolicy_complete
=== RUN   TestAccMobileNetworkSimPolicy_update
=== PAUSE TestAccMobileNetworkSimPolicy_update
=== CONT  TestAccMobileNetworkSimPolicyDataSource_complete
=== CONT  TestAccMobileNetworkSimPolicy_complete
=== CONT  TestAccMobileNetworkSimPolicy_requiresImport
=== CONT  TestAccMobileNetworkSimPolicy_update
=== CONT  TestAccMobileNetworkSimPolicy_basic
--- PASS: TestAccMobileNetworkSimPolicyDataSource_complete (721.25s)
--- PASS: TestAccMobileNetworkSimPolicy_complete (740.29s)
--- PASS: TestAccMobileNetworkSimPolicy_basic (740.33s)
--- PASS: TestAccMobileNetworkSimPolicy_requiresImport (760.68s)
--- PASS: TestAccMobileNetworkSimPolicy_update (938.04s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/mobilenetwork 939.229s

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have some test failures:

------- Stdout: -------
=== RUN   TestAccMobileNetworkSimPolicyDataSource_complete
=== PAUSE TestAccMobileNetworkSimPolicyDataSource_complete
=== CONT  TestAccMobileNetworkSimPolicyDataSource_complete
    testcase.go:110: Step 1/1 error: Error running apply: exit status 1
        
        Error: creating Mobile Network (Subscription: "*******"
        Resource Group Name: "acctest-mn-230303004355330633"
        Mobile Network Name: "acctest-mn-230303004355330633"): performing CreateOrUpdate: mobilenetwork.MobileNetworkClient#CreateOrUpdate: Failure sending request: StatusCode=0 -- Original Error: Code="LocationNotAvailableForResourceType" Message="The provided location 'eastus2' is not available for resource type 'Microsoft.MobileNetwork/mobileNetworks'. List of available regions for the resource type is 'westeurope,eastus'."
        
          with azurerm_mobile_network.test,
          on terraform_plugin_test.tf line 24, in resource "azurerm_mobile_network" "test":
          24: resource "azurerm_mobile_network" "test" {
        
        creating Mobile Network (Subscription: "*******"
        Resource Group Name: "acctest-mn-230303004355330633"
        Mobile Network Name: "acctest-mn-230303004355330633"): performing
        CreateOrUpdate: mobilenetwork.MobileNetworkClient#CreateOrUpdate: Failure
        sending request: StatusCode=0 -- Original Error:
        Code="LocationNotAvailableForResourceType" Message="The provided location
        'eastus2' is not available for resource type
        'Microsoft.MobileNetwork/mobileNetworks'. List of available regions for the
        resource type is 'westeurope,eastus'."
--- FAIL: TestAccMobileNetworkSimPolicyDataSource_complete (61.42s)
FAIL

@ziyeqf
Copy link
Contributor Author

ziyeqf commented Mar 3, 2023

terraform-provider-azurerm ❯ TF_ACC=1 go test -v ./internal/services/mobilenetwork -run=TestAccMobileNetworkSimPolicy -timeout=600m
=== RUN   TestAccMobileNetworkSimPolicyDataSource_complete
=== PAUSE TestAccMobileNetworkSimPolicyDataSource_complete
=== RUN   TestAccMobileNetworkSimPolicy_basic
=== PAUSE TestAccMobileNetworkSimPolicy_basic
=== RUN   TestAccMobileNetworkSimPolicy_requiresImport
=== PAUSE TestAccMobileNetworkSimPolicy_requiresImport
=== RUN   TestAccMobileNetworkSimPolicy_complete
=== PAUSE TestAccMobileNetworkSimPolicy_complete
=== RUN   TestAccMobileNetworkSimPolicy_update
=== PAUSE TestAccMobileNetworkSimPolicy_update
=== CONT  TestAccMobileNetworkSimPolicyDataSource_complete
=== CONT  TestAccMobileNetworkSimPolicy_complete
=== CONT  TestAccMobileNetworkSimPolicy_update
=== CONT  TestAccMobileNetworkSimPolicy_requiresImport
=== CONT  TestAccMobileNetworkSimPolicy_basic
--- PASS: TestAccMobileNetworkSimPolicyDataSource_complete (701.43s)
--- PASS: TestAccMobileNetworkSimPolicy_complete (735.35s)
--- PASS: TestAccMobileNetworkSimPolicy_basic (736.07s)
--- PASS: TestAccMobileNetworkSimPolicy_requiresImport (764.62s)
--- PASS: TestAccMobileNetworkSimPolicy_update (942.74s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/mobilenetwork 943.963s

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 📡

@katbyte katbyte merged commit 9aef594 into hashicorp:main Mar 14, 2023
@github-actions github-actions bot added this to the v3.48.0 milestone Mar 14, 2023
katbyte added a commit that referenced this pull request Mar 14, 2023
@github-actions
Copy link

This functionality has been released in v3.48.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants