Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow storage account container access type change without recreation #2075

Merged
merged 4 commits into from Oct 15, 2018

Conversation

draggeta
Copy link
Contributor

@draggeta draggeta commented Oct 13, 2018

This should fix issue #1686. The fix was quite small as it only needed to have an update function added, which the create function is fully capable of handling.

@ghost ghost added the size/M label Oct 13, 2018
@draggeta draggeta changed the title Allow container access type change without recreation WIP: Allow container access type change without recreation Oct 13, 2018
@draggeta draggeta changed the title WIP: Allow container access type change without recreation Allow container access type change without recreation Oct 14, 2018
@draggeta draggeta changed the title Allow container access type change without recreation Allow storage account container access type change without recreation Oct 14, 2018
@katbyte katbyte added this to the 1.17.0 milestone Oct 15, 2018
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @draggeta,

Thank you for opening this PR! LGTM 👍

@katbyte katbyte merged commit a3f8c81 into hashicorp:master Oct 15, 2018
katbyte added a commit that referenced this pull request Oct 15, 2018
@draggeta draggeta deleted the allow-container-access-type-change branch October 22, 2018 00:53
@ghost
Copy link

ghost commented Mar 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@hashicorp hashicorp locked and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants