azurerm_role_assignment: Allow for sub aliases scopes

[favoretti]

No description provided.

[favoretti]

1 failing is transient and isn't related to the chages.

[manicminer]

Hi @favoretti, thanks for looking at this. I think overall this looks good, I'm just concerned about unit test coverage (see comment below).

[favoretti]

Hi @favoretti, thanks for looking at this. I think overall this looks good, I'm just concerned about unit test coverage (see comment below).

@manicminer Good catch on testing SubscriptionAlias value, thanks for that. Not sure I follow though about IsSubscriptionAliasLevel not being tested below?

[manicminer]

@favoretti Towards the end of the TestRoleAssignmentID() func, there are checks to ensure the returned ID is populated correctly - we'll want to add checks for the IsSubscriptionAliasLevel and SubscriptionAlias` fields, else the test will just pass whatever their value :)

[favoretti]

@manicminer gotcha, pushed a fix.

[katbyte]

LGTM 💡

[github-actions]

This functionality has been released in v3.49.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[PreciousEdmund]

Hi, I have a customer that has issues with this version though
When using this version he gets this error "Error: reading Subscription Alias “Hidden ID”: subscriptions.SubscriptionsClient#AliasGet: Failure responding to request: StatusCode=401 – Original Error: autorest/azure: Service returned an error. Status=401 Code=”UserNotAuthorized” Message=”User does not have access Microsoft.Subscription/aliases/write over scope providers/Microsoft.Subscription/aliases/HiddenID"

But when using the version 3.49.0 everything works out fine.

Hidden ID: To Prevent personal information

[sampathkovuri]

It seems that I am experiencing a similar error as mentioned above, but only with manually created subscriptions. I have several subscriptions that were created programmatically with Terraform, where I am able to upgrade the azurerm provider without any issues. It looks like the alias is not reading or accepting by the terraform which was created outside the terraform.
If anyone has a solution for this problem, please inform me.

[favoretti]

So initial release code in 3.49 worked? Any ideas which release broke it?

[sampathkovuri]

So initial release code in 3.49 worked? Any ideas which release broke it?

It works without any issues with 3.49.0, breaks with all versions above it

[PreciousEdmund]

Oh, glad i'm not the only @sampathkovuri

Please @favoretti , can you look into this

[kivio]

It still doesn't work. Same issues as above with version: "3.82.0"

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.