Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_signalr_service - add public_network_access_enabled, local_auth_enabled, aad_auth_enabled, tls_client_cert_enabled, serverless_connection_timeout_in_seconds that were introduced in latest 2023-02-01 api #20975

Merged
merged 4 commits into from
Mar 21, 2023

Conversation

xiaxyi
Copy link
Contributor

@xiaxyi xiaxyi commented Mar 16, 2023

properties added:

1. public_network_access_enabled
2. local_auth_enabled
3. aad_auth_enabled
4. tls_client_cert_enabled
5. serverless_connection_timeout_in_seconds

@xiaxyi
Copy link
Contributor Author

xiaxyi commented Mar 20, 2023

The acctests are passing and the failed one does not relate to the changes that are made in this pr.
image

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 📡

could you please update the title with the properties added?

@xiaxyi xiaxyi changed the title azurerm_signalr_service - add properties that were introduced in latest 2023-02-01 api azurerm_signalr_service - add public_network_access_enabled, local_auth_enabled, aad_auth_enabled, tls_client_cert_enabled, serverless_connection_timeout_in_seconds that were introduced in latest 2023-02-01 api Mar 21, 2023
@xiaxyi
Copy link
Contributor Author

xiaxyi commented Mar 21, 2023

Thanks @katbyte for the review, added the property in title, will do the same in my future prs.

@katbyte
Copy link
Collaborator

katbyte commented Mar 21, 2023

thanks!

@katbyte katbyte merged commit dd7f580 into hashicorp:main Mar 21, 2023
katbyte added a commit that referenced this pull request Mar 21, 2023
@github-actions github-actions bot added this to the v3.49.0 milestone Mar 21, 2023
@github-actions
Copy link

This functionality has been released in v3.49.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants