Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/application_gateway: validating that firewall_policy_id references the AppGateway Web Application Firewall Policy ID and not the FrontDoor Policy ID #21238

Merged
merged 1 commit into from
Apr 2, 2023

Conversation

tombuildsstuff
Copy link
Contributor

This regression was introduced in #21129, where the ID of a Firewall Policy ID is being validated rather than the ID of an Application Gateway Web Application Firewall ID - which this PR fixes.

This PR also ensures the casing is normalized when reading this back from the API, which'll solve an issue in the future when the casing of the ApplicationGatewayWebApplicationFirewallPolicies segment is updated to camelCase, per the ARM Spec.

Fixes #21224

…s the AppGateway Web Application Firewall Policy ID and not the FrontDoor Policy ID

This commit also ensures the casing is normalized when reading this back from the API, which'll solve an issue in the future when the casing of the
`ApplicationGatewayWebApplicationFirewallPolicies` segment is updated to camelCase, per the ARM Spec.
@tombuildsstuff
Copy link
Contributor Author

Relevant tests:

Screenshot 2023-03-31 at 17 06 11

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@katbyte katbyte merged commit 89d5493 into main Apr 2, 2023
@katbyte katbyte deleted the b/application-gateway-regression-21224 branch April 2, 2023 17:56
katbyte added a commit that referenced this pull request Apr 2, 2023
@github-actions
Copy link

This functionality has been released in v3.51.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with validation of firewall_policy_id for azurerm_application_gateway added in v3.50.0
3 participants