azurerm_backup_policy_vm - Support for the days and include_last_days properties

[ziyeqf]

support day based retention config.

Test

❯ tftest recoveryservices TestAccBackupProtectionPolicyVM
=== RUN   TestAccBackupProtectionPolicyVM_policyTypeDefault
=== PAUSE TestAccBackupProtectionPolicyVM_policyTypeDefault
=== RUN   TestAccBackupProtectionPolicyVM_basicDaily
=== PAUSE TestAccBackupProtectionPolicyVM_basicDaily
=== RUN   TestAccBackupProtectionPolicyVM_withInstantRestoreRetentionRangeUpdate
=== PAUSE TestAccBackupProtectionPolicyVM_withInstantRestoreRetentionRangeUpdate
=== RUN   TestAccBackupProtectionPolicyVM_requiresImport
=== PAUSE TestAccBackupProtectionPolicyVM_requiresImport
=== RUN   TestAccBackupProtectionPolicyVM_basicWeekly
=== PAUSE TestAccBackupProtectionPolicyVM_basicWeekly
=== RUN   TestAccBackupProtectionPolicyVM_completeDaily
=== PAUSE TestAccBackupProtectionPolicyVM_completeDaily
=== RUN   TestAccBackupProtectionPolicyVM_completeWeekly
=== PAUSE TestAccBackupProtectionPolicyVM_completeWeekly
=== RUN   TestAccBackupProtectionPolicyVM_updateDaily
=== PAUSE TestAccBackupProtectionPolicyVM_updateDaily
=== RUN   TestAccBackupProtectionPolicyVM_updateWeekly
=== PAUSE TestAccBackupProtectionPolicyVM_updateWeekly
=== RUN   TestAccBackupProtectionPolicyVM_updateDailyToWeekly
=== PAUSE TestAccBackupProtectionPolicyVM_updateDailyToWeekly
=== RUN   TestAccBackupProtectionPolicyVM_updateWeeklyToDaily
=== PAUSE TestAccBackupProtectionPolicyVM_updateWeeklyToDaily
=== RUN   TestAccBackupProtectionPolicyVM_updateWeeklyToPartial
=== PAUSE TestAccBackupProtectionPolicyVM_updateWeeklyToPartial
=== RUN   TestAccBackupProtectionPolicyVM_basicHourlyV2
=== PAUSE TestAccBackupProtectionPolicyVM_basicHourlyV2
=== RUN   TestAccBackupProtectionPolicyVM_basicDailyV2
=== PAUSE TestAccBackupProtectionPolicyVM_basicDailyV2
=== RUN   TestAccBackupProtectionPolicyVM_withInstantRestoreRetentionRangeUpdateV2
=== PAUSE TestAccBackupProtectionPolicyVM_withInstantRestoreRetentionRangeUpdateV2
=== RUN   TestAccBackupProtectionPolicyVM_basicWeeklyV2
=== PAUSE TestAccBackupProtectionPolicyVM_basicWeeklyV2
=== RUN   TestAccBackupProtectionPolicyVM_completeHourlyV2
=== PAUSE TestAccBackupProtectionPolicyVM_completeHourlyV2
=== RUN   TestAccBackupProtectionPolicyVM_completeDailyV2
=== PAUSE TestAccBackupProtectionPolicyVM_completeDailyV2
=== RUN   TestAccBackupProtectionPolicyVM_completeWeeklyV2
=== PAUSE TestAccBackupProtectionPolicyVM_completeWeeklyV2
=== RUN   TestAccBackupProtectionPolicyVM_updateHourlyV2
=== PAUSE TestAccBackupProtectionPolicyVM_updateHourlyV2
=== RUN   TestAccBackupProtectionPolicyVM_updateDailyV2
=== PAUSE TestAccBackupProtectionPolicyVM_updateDailyV2
=== RUN   TestAccBackupProtectionPolicyVM_updateWeeklyV2
=== PAUSE TestAccBackupProtectionPolicyVM_updateWeeklyV2
=== RUN   TestAccBackupProtectionPolicyVM_updateHourlyAndWeeklyV2
=== PAUSE TestAccBackupProtectionPolicyVM_updateHourlyAndWeeklyV2
=== RUN   TestAccBackupProtectionPolicyVM_updateDailyAndWeeklyV2
=== PAUSE TestAccBackupProtectionPolicyVM_updateDailyAndWeeklyV2
=== RUN   TestAccBackupProtectionPolicyVM_updateWeeklyToPartialV2
=== PAUSE TestAccBackupProtectionPolicyVM_updateWeeklyToPartialV2
=== RUN   TestAccBackupProtectionPolicyVM_withCustomRGName
=== PAUSE TestAccBackupProtectionPolicyVM_withCustomRGName
=== RUN   TestAccBackupProtectionPolicyVM_basicDays
=== PAUSE TestAccBackupProtectionPolicyVM_basicDays
=== RUN   TestAccBackupProtectionPolicyVM_completeDays
=== PAUSE TestAccBackupProtectionPolicyVM_completeDays
=== RUN   TestAccBackupProtectionPolicyVMWorkload_basic
=== PAUSE TestAccBackupProtectionPolicyVMWorkload_basic
=== RUN   TestAccBackupProtectionPolicyVMWorkload_update
=== PAUSE TestAccBackupProtectionPolicyVMWorkload_update
=== CONT  TestAccBackupProtectionPolicyVM_policyTypeDefault
=== CONT  TestAccBackupProtectionPolicyVM_basicWeeklyV2
=== CONT  TestAccBackupProtectionPolicyVM_updateDailyAndWeeklyV2
=== CONT  TestAccBackupProtectionPolicyVM_completeDays
=== CONT  TestAccBackupProtectionPolicyVM_updateHourlyV2
=== CONT  TestAccBackupProtectionPolicyVM_completeDailyV2
=== CONT  TestAccBackupProtectionPolicyVM_completeWeeklyV2
=== CONT  TestAccBackupProtectionPolicyVMWorkload_update
--- PASS: TestAccBackupProtectionPolicyVM_completeDays (541.97s)
=== CONT  TestAccBackupProtectionPolicyVM_withCustomRGName
--- PASS: TestAccBackupProtectionPolicyVM_policyTypeDefault (580.11s)
=== CONT  TestAccBackupProtectionPolicyVM_basicDays
--- PASS: TestAccBackupProtectionPolicyVM_completeDailyV2 (615.26s)
=== CONT  TestAccBackupProtectionPolicyVM_updateWeeklyV2
--- PASS: TestAccBackupProtectionPolicyVM_basicWeeklyV2 (660.94s)
=== CONT  TestAccBackupProtectionPolicyVM_updateHourlyAndWeeklyV2
--- PASS: TestAccBackupProtectionPolicyVM_completeWeeklyV2 (732.57s)
=== CONT  TestAccBackupProtectionPolicyVM_updateDailyV2
--- PASS: TestAccBackupProtectionPolicyVM_updateHourlyV2 (812.59s)
=== CONT  TestAccBackupProtectionPolicyVMWorkload_basic
--- PASS: TestAccBackupProtectionPolicyVMWorkload_update (931.05s)
=== CONT  TestAccBackupProtectionPolicyVM_updateDaily
--- PASS: TestAccBackupProtectionPolicyVM_updateDailyAndWeeklyV2 (987.95s)
=== CONT  TestAccBackupProtectionPolicyVM_updateWeekly
--- PASS: TestAccBackupProtectionPolicyVM_withCustomRGName (572.60s)
=== CONT  TestAccBackupProtectionPolicyVM_completeWeekly
=== NAME  TestAccBackupProtectionPolicyVM_basicDays
    testing_new.go:86: Error running post-test destroy, there may be dangling resources: exit status 1
        
        Error: deleting Vault (Subscription: "85b3dbca-5974-4067-9669-67a141095a76"
        Resource Group Name: "acctestRG-backup-230428102128192589"
        Vault Name: "acctest-230428102128192589"): vaults.VaultsClient#Delete: Failure responding to request: StatusCode=204 -- Original Error: autorest/azure: error response cannot be parsed: {"" '\x00' '\x00'} error: EOF
        
--- FAIL: TestAccBackupProtectionPolicyVM_basicDays (615.31s)
=== CONT  TestAccBackupProtectionPolicyVM_withInstantRestoreRetentionRangeUpdateV2
--- PASS: TestAccBackupProtectionPolicyVM_updateDaily (470.73s)
=== CONT  TestAccBackupProtectionPolicyVM_requiresImport
--- PASS: TestAccBackupProtectionPolicyVMWorkload_basic (609.27s)
=== CONT  TestAccBackupProtectionPolicyVM_withInstantRestoreRetentionRangeUpdate
--- PASS: TestAccBackupProtectionPolicyVM_updateWeeklyV2 (900.37s)
=== CONT  TestAccBackupProtectionPolicyVM_basicHourlyV2
--- PASS: TestAccBackupProtectionPolicyVM_updateWeekly (804.27s)
=== CONT  TestAccBackupProtectionPolicyVM_basicDaily
--- PASS: TestAccBackupProtectionPolicyVM_completeWeekly (682.09s)
=== CONT  TestAccBackupProtectionPolicyVM_updateWeeklyToPartial
--- PASS: TestAccBackupProtectionPolicyVM_updateHourlyAndWeeklyV2 (1135.90s)
=== CONT  TestAccBackupProtectionPolicyVM_updateWeeklyToPartialV2
--- PASS: TestAccBackupProtectionPolicyVM_updateDailyV2 (1064.27s)
=== CONT  TestAccBackupProtectionPolicyVM_updateWeeklyToDaily
--- PASS: TestAccBackupProtectionPolicyVM_requiresImport (576.86s)
=== CONT  TestAccBackupProtectionPolicyVM_basicWeekly
--- PASS: TestAccBackupProtectionPolicyVM_basicHourlyV2 (631.78s)
=== CONT  TestAccBackupProtectionPolicyVM_basicDailyV2
--- PASS: TestAccBackupProtectionPolicyVM_basicDaily (490.43s)
=== CONT  TestAccBackupProtectionPolicyVM_updateDailyToWeekly
--- PASS: TestAccBackupProtectionPolicyVM_withInstantRestoreRetentionRangeUpdateV2 (1145.69s)
=== CONT  TestAccBackupProtectionPolicyVM_completeDaily
--- PASS: TestAccBackupProtectionPolicyVM_withInstantRestoreRetentionRangeUpdate (957.68s)
=== CONT  TestAccBackupProtectionPolicyVM_completeHourlyV2
--- PASS: TestAccBackupProtectionPolicyVM_updateWeeklyToPartialV2 (677.80s)
--- PASS: TestAccBackupProtectionPolicyVM_basicWeekly (641.05s)
--- PASS: TestAccBackupProtectionPolicyVM_updateWeeklyToPartial (828.55s)
--- PASS: TestAccBackupProtectionPolicyVM_basicDailyV2 (497.91s)
--- PASS: TestAccBackupProtectionPolicyVM_updateWeeklyToDaily (898.28s)
--- PASS: TestAccBackupProtectionPolicyVM_completeHourlyV2 (442.40s)
--- PASS: TestAccBackupProtectionPolicyVM_completeDaily (491.31s)
--- PASS: TestAccBackupProtectionPolicyVM_updateDailyToWeekly (669.80s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-azurerm/internal/services/recoveryservices      2952.532s
FAIL

rerun the failed one

❯ tftest recoveryservices TestAccBackupProtectionPolicyVM_basicDays
=== RUN   TestAccBackupProtectionPolicyVM_basicDays
=== PAUSE TestAccBackupProtectionPolicyVM_basicDays
=== CONT  TestAccBackupProtectionPolicyVM_basicDays
--- PASS: TestAccBackupProtectionPolicyVM_basicDays (612.34s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/recoveryservices      612.385s

[katbyte]

@ziyeqf - you'll need to cherryh pick the PR commits ontop of main to fix the force push

[katbyte]

LGTM 📆

[github-actions]

This functionality has been released in v3.58.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.