-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/attestation_provider: conditionally building the Authorizer as needed and refactoring the Resource #21524
Conversation
… fields This is an unfortunate but intentional breaking change - needed since the `policy` field doesn't accurately map the API behaviour.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 📘
This functionality has been released in v3.54.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Part of reviewing #21509 has identified a number of issues with the PR submitted to add support for this, #20972.
This PR fixes both #21508 - and works to fix some design issues which should have been caught at both implementation and review phase - namely where:
environment_type
keys are consistent, these should have been exposed as individual fields for each Policy Type - whilst changing that prior to 4.0 would be a breaking change, since we can read these values back from the API (see the next item) this would need to become a Set rather than a List.policy
block doesn't accurately model the API behaviour - as such we'll need to make these top-level fields instead.tombuildsstuff/kermit
(orhashicorp/go-azure-sdk
for Resource Manager endpoints) - at this point importing Track1 SDK's is adding technical debt - importing this into eitherkermit
orgo-azure-sdk
means this doesn't need to be updated later.This PR addresses most of these issues, with the exception of number 5, which is available via
tombuildsstuff/kermit
(as ofv0.20230424.1090808
) - but isn't part of this PR.Fixes #21508