Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_backup_policy_file_share - support day-based retention policy, support hourly backup schedule #21529

Merged
merged 4 commits into from
Jun 6, 2023

Conversation

ziyeqf
Copy link
Contributor

@ziyeqf ziyeqf commented Apr 25, 2023

test

❯ tftest recoveryservices TestAccBackupProtectionPolicyFileShare
=== RUN   TestAccBackupProtectionPolicyFileShare_basicDaily
=== PAUSE TestAccBackupProtectionPolicyFileShare_basicDaily
=== RUN   TestAccBackupProtectionPolicyFileShare_basicHourly
=== PAUSE TestAccBackupProtectionPolicyFileShare_basicHourly
=== RUN   TestAccBackupProtectionPolicyFileShare_requiresImport
=== PAUSE TestAccBackupProtectionPolicyFileShare_requiresImport
=== RUN   TestAccBackupProtectionPolicyFileShare_WeeklyRetention
=== PAUSE TestAccBackupProtectionPolicyFileShare_WeeklyRetention
=== RUN   TestAccBackupProtectionPolicyFileShare_WeeklyRetentionImport
=== PAUSE TestAccBackupProtectionPolicyFileShare_WeeklyRetentionImport
=== RUN   TestAccBackupProtectionPolicyFileShare_MonthlyRetention
=== PAUSE TestAccBackupProtectionPolicyFileShare_MonthlyRetention
=== RUN   TestAccBackupProtectionPolicyFileShare_MonthlyRetentionImport
=== PAUSE TestAccBackupProtectionPolicyFileShare_MonthlyRetentionImport
=== RUN   TestAccBackupProtectionPolicyFileShare_YearlyRetention
=== PAUSE TestAccBackupProtectionPolicyFileShare_YearlyRetention
=== RUN   TestAccBackupProtectionPolicyFileShare_YearlyRetentionImport
=== PAUSE TestAccBackupProtectionPolicyFileShare_YearlyRetentionImport
=== RUN   TestAccBackupProtectionPolicyFileShare_completeDaily
=== PAUSE TestAccBackupProtectionPolicyFileShare_completeDaily
=== RUN   TestAccBackupProtectionPolicyFileShare_updateDaily
=== PAUSE TestAccBackupProtectionPolicyFileShare_updateDaily
=== RUN   TestAccBackupProtectionPolicyFileShare_updateDailyRetentionToWeekly
=== PAUSE TestAccBackupProtectionPolicyFileShare_updateDailyRetentionToWeekly
=== RUN   TestAccBackupProtectionPolicyFileShare_updateWeeklyRetentionToMonthly
=== PAUSE TestAccBackupProtectionPolicyFileShare_updateWeeklyRetentionToMonthly
=== RUN   TestAccBackupProtectionPolicyFileShare_updateMonthlyRetentionToYearly
=== PAUSE TestAccBackupProtectionPolicyFileShare_updateMonthlyRetentionToYearly
=== RUN   TestAccBackupProtectionPolicyFileShare_updateYearlyRetentionToDaily
=== PAUSE TestAccBackupProtectionPolicyFileShare_updateYearlyRetentionToDaily
=== RUN   TestAccBackupProtectionPolicyFileShare_updateDailyToPartial
=== PAUSE TestAccBackupProtectionPolicyFileShare_updateDailyToPartial
=== RUN   TestAccBackupProtectionPolicyFileShare_basicDays
=== PAUSE TestAccBackupProtectionPolicyFileShare_basicDays
=== RUN   TestAccBackupProtectionPolicyFileShare_completeDays
=== PAUSE TestAccBackupProtectionPolicyFileShare_completeDays
=== CONT  TestAccBackupProtectionPolicyFileShare_basicDaily
=== CONT  TestAccBackupProtectionPolicyFileShare_completeDaily
=== CONT  TestAccBackupProtectionPolicyFileShare_updateYearlyRetentionToDaily
=== CONT  TestAccBackupProtectionPolicyFileShare_updateDailyRetentionToWeekly
=== CONT  TestAccBackupProtectionPolicyFileShare_updateWeeklyRetentionToMonthly
=== CONT  TestAccBackupProtectionPolicyFileShare_MonthlyRetention
=== CONT  TestAccBackupProtectionPolicyFileShare_updateDaily
=== CONT  TestAccBackupProtectionPolicyFileShare_basicDays
--- PASS: TestAccBackupProtectionPolicyFileShare_basicDays (468.55s)
=== CONT  TestAccBackupProtectionPolicyFileShare_completeDays
--- PASS: TestAccBackupProtectionPolicyFileShare_completeDaily (548.00s)
=== CONT  TestAccBackupProtectionPolicyFileShare_updateDailyToPartial
--- PASS: TestAccBackupProtectionPolicyFileShare_updateYearlyRetentionToDaily (661.39s)
=== CONT  TestAccBackupProtectionPolicyFileShare_WeeklyRetention
--- PASS: TestAccBackupProtectionPolicyFileShare_updateDailyRetentionToWeekly (680.75s)
=== CONT  TestAccBackupProtectionPolicyFileShare_WeeklyRetentionImport
--- PASS: TestAccBackupProtectionPolicyFileShare_MonthlyRetention (693.79s)
=== CONT  TestAccBackupProtectionPolicyFileShare_YearlyRetention
--- PASS: TestAccBackupProtectionPolicyFileShare_updateDaily (705.58s)
=== CONT  TestAccBackupProtectionPolicyFileShare_MonthlyRetentionImport
--- PASS: TestAccBackupProtectionPolicyFileShare_updateWeeklyRetentionToMonthly (716.50s)
=== CONT  TestAccBackupProtectionPolicyFileShare_YearlyRetentionImport
--- PASS: TestAccBackupProtectionPolicyFileShare_basicDaily (721.63s)
=== CONT  TestAccBackupProtectionPolicyFileShare_requiresImport
--- PASS: TestAccBackupProtectionPolicyFileShare_completeDays (549.60s)
=== CONT  TestAccBackupProtectionPolicyFileShare_basicHourly
--- PASS: TestAccBackupProtectionPolicyFileShare_requiresImport (409.23s)
=== CONT  TestAccBackupProtectionPolicyFileShare_updateMonthlyRetentionToYearly
--- PASS: TestAccBackupProtectionPolicyFileShare_WeeklyRetention (518.90s)
--- PASS: TestAccBackupProtectionPolicyFileShare_WeeklyRetentionImport (505.73s)
--- PASS: TestAccBackupProtectionPolicyFileShare_YearlyRetention (504.11s)
--- PASS: TestAccBackupProtectionPolicyFileShare_MonthlyRetentionImport (521.98s)
--- PASS: TestAccBackupProtectionPolicyFileShare_YearlyRetentionImport (564.65s)
--- PASS: TestAccBackupProtectionPolicyFileShare_updateDailyToPartial (771.12s)
--- PASS: TestAccBackupProtectionPolicyFileShare_basicHourly (483.39s)
--- PASS: TestAccBackupProtectionPolicyFileShare_updateMonthlyRetentionToYearly (661.30s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/recoveryservices      1792.226s

…y, hourly backup schedule

Signed-off-by: ziyeqf <51212351+ziyeqf@users.noreply.github.com>
@ziyeqf ziyeqf force-pushed the tengzh/recovery/policy/storage branch from c76a030 to e89fc1d Compare April 28, 2023 03:15
Signed-off-by: ziyeqf <51212351+ziyeqf@users.noreply.github.com>
Signed-off-by: ziyeqf <51212351+ziyeqf@users.noreply.github.com>
@ziyeqf
Copy link
Contributor Author

ziyeqf commented Jun 6, 2023

Screenshot 2023-06-06 at 11 53 15

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🕥

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants