dependencies: managed applications: swap to hashicorp/go-azure-sdk
#21571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
service/managed-apps
size/XL
waiting-response
labels
tombuildsstuff
force-pushed
the
kt/managed-pandora-applications
branch
from
f8c0f84
to
dcb86b2
Compare
|
Cherry-picked this commit atop of |
tombuildsstuff
requested changes
Apr 28, 2023
There was a problem hiding this comment.
hey @katbyte
Thanks for this PR - I've taken a look through and left some comments inline - I think it'd be worth being a little more consistent across resources here to make PR review easier, namely using model, props and payload as known variables, so that when reviewing PR's we don't need to repeatedly keep track of different variable names? It's minor but I think the consistency would be beneficial?
Thanks!
internal/services/managedapplications/managed_application_definition_data_source.go
Outdated
Show resolved
Hide resolved
internal/services/managedapplications/managed_application_definition_resource.go
Outdated
Show resolved
Hide resolved
internal/services/managedapplications/managed_application_definition_resource.go
Outdated
Show resolved
Hide resolved
internal/services/managedapplications/managed_application_resource.go
Outdated
Show resolved
Hide resolved
internal/services/managedapplications/managed_application_resource.go
Outdated
Show resolved
Hide resolved
internal/services/managedapplications/managed_application_resource.go
Outdated
Show resolved
Hide resolved
internal/services/managedapplications/managed_application_resource.go
Outdated
Show resolved
Hide resolved
internal/services/managedapplications/managed_application_resource_test.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
…urce_test.go Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
…nition_resource.go Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
…nition_resource.go Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
…nition_resource.go Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
…nition_resource_test.go Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
…urce.go Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
katbyte
commented
May 24, 2023
internal/services/managedapplications/managed_application_resource.go
Outdated
Show resolved
Hide resolved
mbfrahry
changed the title
hashicorp/go-azure-sdk
mbfrahry
added a commit
that referenced
this pull request
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.