Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_key_vault: set createMode as default in create instead of null #21668

Merged
merged 1 commit into from
May 24, 2023

Conversation

wuxu92
Copy link
Contributor

@wuxu92 wuxu92 commented May 5, 2023

always set createMode when creating a keyvault instance. resolves: #21334

--- PASS: TestAccKeyVault_basic (401.95s)
PASS

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏖️

@katbyte katbyte merged commit 6a3b908 into hashicorp:main May 24, 2023
12 checks passed
@github-actions github-actions bot added this to the v3.58.0 milestone May 24, 2023
katbyte added a commit that referenced this pull request May 24, 2023
@github-actions
Copy link

This functionality has been released in v3.58.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@wuxu92 wuxu92 deleted the kv/createmode branch June 5, 2023 02:23
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure Key Vault createMode setup
2 participants