azurerm_app_configuration - retry checkNameAvailability to make sure delete is finished, add stateWait to confirm key/feature is created

[teowa]

resolves #21939

• add the state.WaitForStateContext to fix Root resource was present, but now absent error of azurerm_app_configuration_key/feature.
• add the state.WaitForStateContext to retry checkNameAvailability accoding to azurerm_app_configuration - support for the encrption, local_auth_enabled, public_network_access_enabled, purge_protection_enabled,and soft_delete_retention_days properties #17714 (comment).

TF_ACC=1 go test -v ./internal/services/appconfiguration -parallel 50 -test.run=TestAccAppConfiguration_softDeletePurgeThenRecreate -timeout 1440m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAppConfiguration_softDeletePurgeThenRecreate
=== PAUSE TestAccAppConfiguration_softDeletePurgeThenRecreate
=== CONT  TestAccAppConfiguration_softDeletePurgeThenRecreate
--- PASS: TestAccAppConfiguration_softDeletePurgeThenRecreate (556.89s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/appconfiguration      558.142s

[stephybun]

------- Stdout: -------
=== RUN   TestAccAppConfiguration_softDeleteRecovery
=== PAUSE TestAccAppConfiguration_softDeleteRecovery
=== CONT  TestAccAppConfiguration_softDeleteRecovery
testcase.go:110: Step 4/5 error: Error running apply: exit status 1
Error: waiting for the Configuration Store Configuration Store (Subscription: "*******"
Resource Group Name: "acctestRG-appconfig-230511054705781851"
Configuration Store Name: "testaccappconf230511054705781851") Name Available: timeout while waiting for state to become 'Available' (last state: 'Unavailable', timeout: 29m59.517047832s)
with azurerm_app_configuration.test,
on terraform_plugin_test.tf line 22, in resource "azurerm_app_configuration" "test":
22: resource "azurerm_app_configuration" "test" {
--- FAIL: TestAccAppConfiguration_softDeleteRecovery (1892.83s)
FAIL

[katbyte]

I'm getting a test failure:

------- Stdout: -------
=== RUN   TestAccAppConfigurationKey_basicVault
=== PAUSE TestAccAppConfigurationKey_basicVault
=== CONT  TestAccAppConfigurationKey_basicVault
    testcase.go:110: Step 1/2 error: Error running apply: exit status 1
        
        Error: Provider produced inconsistent result after apply
        
        When applying changes to azurerm_app_configuration_key.test, provider
        "provider[\"registry.terraform.io/hashicorp/azurerm\"]" produced an
        unexpected new value: Root resource was present, but now absent.
        
        This is a bug in the provider, which should be reported in the provider's own
        issue tracker.
--- FAIL: TestAccAppConfigurationKey_basicVault (409.06s)
FAIL

[katbyte]

still seeing test failures

[teowa]

Need to fix tests

[teowa]

[stephybun]

Can you please add a test for azurerm_app_configuration_feature and azurerm_app_configuration_key to validate that the wait functions after creation is actually needed?

[teowa]

Hi @stephybun, thanks for reviewing this. I think it is hard to validate wait function is needed, for the produced an unexpected new value: Root resource was present, but now absent error is not 100% reproducible. The wait function is added based on the error from test subscription and customer provided error message in #21939. I have also report the error to service team through Azure/AppConfiguration#763

[stephybun]

Thanks @teowa LGTM 🌻