azurerm_cosmosdb_account - fix for upstream Microsoft API updating identity and default_identity at the same time silently fails issue
#21780
Conversation
github-actions
bot
added
documentation
service/cosmosdb
size/XL
waiting-response
labels
WodansSon
changed the title
azurerm_cosmosdb_account - Updating identities and default identity at the same time silently failsazurerm_cosmosdb_account - Updating identity and default_identity at the same time silently fails
WodansSon
changed the title
azurerm_cosmosdb_account - Updating identity and default_identity at the same time silently failsazurerm_cosmosdb_account - fix for upstream Microsoft API updating identity and default_identity at the same time silently fails issue
WodansSon
added
the
upstream/microsoft
|
Test Pass against PR: Test Pass against Main: |
There was a problem hiding this comment.
Left a couple of comments in-line, but skimming through this otherwise looks alright - @katbyte has the most context of CosmosDB and should give this a second review, however
| err = resourceCosmosDbAccountApiUpsert(client, ctx, id.ResourceGroup, id.Name, account, d) | ||
| if err != nil { | ||
| return fmt.Errorf("updating %s locations: %+v", id, err) | ||
| d.SetId(id.ID()) |
There was a problem hiding this comment.
whilst outside the scope of this PR - the ID shouldn't change during the Update, so we can remove this:
| d.SetId(id.ID()) |
There was a problem hiding this comment.
It was like that, so I didn't know if it was some special logic for the CosmosDB or not so I didn't touch it. 🙂
Fixed.
|
This functionality has been released in v3.58.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Fixes:
This is a mess and a total nightmare due to the Azure Bug: 2209567, however I feel this is the best we can do within the provider to compensate for that issue.