Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data.azurerm_kubernetes_cluster - Fix nil panic by amending nil check #21867

Merged
merged 1 commit into from
May 22, 2023
Merged

data.azurerm_kubernetes_cluster - Fix nil panic by amending nil check #21867

merged 1 commit into from
May 22, 2023

Conversation

lonegunmanb
Copy link
Contributor

#21850 was not sufficient to fix the potential nil panic, this pr added extra nil checks to fix #21840.

@lonegunmanb lonegunmanb mentioned this pull request May 22, 2023
Closed
1 task
@lonegunmanb
Copy link
Contributor Author

lonegunmanb commented May 22, 2023 •
edited
Loading

Hi @katbyte would you please review this pr since my previous pr is insufficient to fix the nil panic? Apology for the inconvenience and thanks for your help!

catriona-m
catriona-m approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lonegunmanb LGTM!

@catriona-m catriona-m merged commit 358b47a into hashicorp:main May 22, 2023
12 checks passed
@github-actions github-actions bot added this to the v3.57.0 milestone May 22, 2023
catriona-m added a commit that referenced this pull request May 22, 2023
@catriona-m
Update CHANGELOG.md for #21867
504c4b4
@lonegunmanb lonegunmanb deleted the f-21840 branch May 22, 2023 13:04
@github-actions
Copy link

This functionality has been released in v3.57.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@catriona-m catriona-m catriona-m approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
v3.57.0
Development

Successfully merging this pull request may close these issues.

Data Source azurerm_kubernetes_cluster nil pointer
2 participants
@lonegunmanb @catriona-m