containerservice - add support for customCATrustCertificates
#22032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this PR @Vegoo89. Would you mind rebasing since we upgraded the SDK to an even later version? |
|
Will do when I am back from vacation in two weeks :) |
Vegoo89
force-pushed
the
custom_ca_trust_certificates
branch
from
cbc2bb2
to
d6952b5
Compare
github-actions
bot
added
size/L
and removed
dependencies
service/machine-learning
service/mobile-network
size/XL
labels
|
@stephybun please take a look, thanks! |
Vegoo89
changed the title
containerservice - upgrade sdk to 2023-03-02-preview & add support for customCATrustCertificatescontainerservice - add support for customCATrustCertificates
stephybun
requested changes
Jun 26, 2023
internal/services/containers/kubernetes_cluster_resource_test.go
Outdated
Show resolved
Hide resolved
internal/services/containers/kubernetes_cluster_resource_test.go
Outdated
Show resolved
Hide resolved
|
@stephybun changes have been implemented (hopefully its fine). I left comments for two conversations. |
stephybun
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21284
This PR adds support for
customCATrustCertificatesinManagedClusterSecurityProfileblockMicrosoft documentation:
https://learn.microsoft.com/en-us/azure/templates/microsoft.containerservice/2023-03-02-preview/managedclusters?pivots=deployment-language-bicep#managedclustersecurityprofile