Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_monitor_autoscale_setting - support for predictive block #22038

Merged
merged 6 commits into from
Jun 9, 2023
Merged

azurerm_monitor_autoscale_setting - support for predictive block #22038

merged 6 commits into from
Jun 9, 2023

Conversation

teowa
Copy link
Contributor

@teowa teowa commented Jun 5, 2023 •
edited
Loading

magodo
magodo requested changes Jun 6, 2023
View reviewed changes
Copy link
Collaborator

@magodo magodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!
I've taken a look through and left some comments inline, but this is mostly looking good to me 👍

internal/services/monitor/monitor_autoscale_setting_resource.go Outdated Show resolved Hide resolved
internal/services/monitor/monitor_autoscale_setting_resource.go Outdated Show resolved Hide resolved
internal/services/monitor/monitor_autoscale_setting_resource.go Outdated Show resolved Hide resolved
magodo
magodo requested changes Jun 6, 2023
View reviewed changes
Copy link
Collaborator

@magodo magodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!
I have left some additional mostly minor comments that once addressed this should be good to merge 👍

internal/services/monitor/monitor_autoscale_setting_resource.go Outdated Show resolved Hide resolved
katbyte
katbyte approved these changes Jun 9, 2023
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🧮

@katbyte katbyte merged commit 9fae4b1 into hashicorp:main Jun 9, 2023
14 checks passed
@github-actions github-actions bot added this to the v3.60.0 milestone Jun 9, 2023
katbyte added a commit that referenced this pull request Jun 9, 2023
@katbyte
Update CHANGELOG.md #22038
72c8cc3
@teowa teowa changed the title azurerm_monitor_autoscale_setting - support for predictive_scale_mode and predictive_scale_look_ahead_time properties azurerm_monitor_autoscale_setting - support for predictive block Jun 15, 2023
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff left review comments

@magodo magodo magodo requested changes

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation enhancement service/monitor size/L
Projects
None yet
Milestone
v3.60.0
Development

Successfully merging this pull request may close these issues.

VMSS predictive autoscale
4 participants
@teowa @tombuildsstuff @katbyte @magodo