Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_automanage_configuration - support new property block log_analytics_enabled #22121

Merged
merged 4 commits into from Jun 12, 2023

Conversation

liuwuliuyun
Copy link
Contributor

@liuwuliuyun liuwuliuyun commented Jun 12, 2023

This is the third PR for azurerm_automanage_configuration, In this PR,

  • new property log_analytics_enabled is supported

Note that

  • For trustedLaunchVM/Backup -> All property results in 400 Error so we are not able to support those properties.
  • For logAnalytics other properties also result 400 in tests and not able to support.

Previous PR: #22081

Swagger Link: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/automanage/resource-manager/Microsoft.Automanage/stable/2022-05-04/automanage.json

@liuwuliuyun
Copy link
Contributor Author

Testing evidence:

GOROOT=C:\Users\yunliu1\go\go1.19.3 #gosetup
GOPATH=C:\Users\yunliu1\go #gosetup
C:\Users\yunliu1\go\go1.19.3\bin\go.exe test -c -o C:\Users\yunliu1\AppData\Local\JetBrains\GoLand2023.1\tmp\GoLand\___go_test_github_com_hashicorp_terraform_provider_azurerm_internal_services_automanage.test.exe github.com/hashicorp/terraform-provider-azurerm/internal/services/automanage #gosetup
C:\Users\yunliu1\go\go1.19.3\bin\go.exe tool test2json -t C:\Users\yunliu1\AppData\Local\JetBrains\GoLand2023.1\tmp\GoLand\___go_test_github_com_hashicorp_terraform_provider_azurerm_internal_services_automanage.test.exe -test.v -test.paniconexit0 #gosetup
=== RUN   TestAccAutoManageConfigurationProfile_basic
=== PAUSE TestAccAutoManageConfigurationProfile_basic
=== CONT  TestAccAutoManageConfigurationProfile_basic
--- PASS: TestAccAutoManageConfigurationProfile_basic (170.39s)
=== RUN   TestAccAutoManageConfigurationProfile_antimalware
=== PAUSE TestAccAutoManageConfigurationProfile_antimalware
=== CONT  TestAccAutoManageConfigurationProfile_antimalware
--- PASS: TestAccAutoManageConfigurationProfile_antimalware (149.34s)
=== RUN   TestAccAutoManageConfigurationProfile_azureSecurityBaseline
=== PAUSE TestAccAutoManageConfigurationProfile_azureSecurityBaseline
=== CONT  TestAccAutoManageConfigurationProfile_azureSecurityBaseline
--- PASS: TestAccAutoManageConfigurationProfile_azureSecurityBaseline (178.36s)
=== RUN   TestAccAutoManageConfigurationProfile_requiresImport
=== PAUSE TestAccAutoManageConfigurationProfile_requiresImport
=== CONT  TestAccAutoManageConfigurationProfile_requiresImport
--- PASS: TestAccAutoManageConfigurationProfile_requiresImport (173.13s)
=== RUN   TestAccAutoManageConfigurationProfile_backup
=== PAUSE TestAccAutoManageConfigurationProfile_backup
=== CONT  TestAccAutoManageConfigurationProfile_backup
--- PASS: TestAccAutoManageConfigurationProfile_backup (175.58s)
=== RUN   TestAccAutoManageConfigurationProfile_logAnalytics
=== PAUSE TestAccAutoManageConfigurationProfile_logAnalytics
=== CONT  TestAccAutoManageConfigurationProfile_logAnalytics
--- PASS: TestAccAutoManageConfigurationProfile_logAnalytics (203.68s)
=== RUN   TestAccAutoManageConfigurationProfile_complete
=== PAUSE TestAccAutoManageConfigurationProfile_complete
=== CONT  TestAccAutoManageConfigurationProfile_complete
--- PASS: TestAccAutoManageConfigurationProfile_complete (112.59s)
=== RUN   TestAccAutoManageConfigurationProfile_update
=== PAUSE TestAccAutoManageConfigurationProfile_update
=== CONT  TestAccAutoManageConfigurationProfile_update
--- PASS: TestAccAutoManageConfigurationProfile_update (148.35s)
PASS


Process finished with the exit code 0

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤖

@katbyte katbyte merged commit 2b8e0f8 into hashicorp:main Jun 12, 2023
14 checks passed
katbyte added a commit that referenced this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants