New Data Source: azurerm_eventhub_sas #22215
Conversation
|
@katbyte , thanks for the comment. I replied it. Please take another look. Thanks. |
There was a problem hiding this comment.
Per my inline comment above, I think the escape sequence issue should be fixed in the data source (or helper func, or SDK).
github-actions
bot
added
service/hdinsight
service/iot-hub
service/firewall
service/event-grid
neil-yechenwei
force-pushed
the
eventhubsastoken
branch
from
b021179
to
37de341
Compare
|
@manicminer , thanks for the comment. I replied it. Please take another look. Thanks.
|
There was a problem hiding this comment.
Thanks @neil-yechenwei, is there a reason this is an untyped data source? New data sources should use the typed SDK unless there is a compelling reason not to.
|
@manicminer , I made this PR on my local about 2 years ago and this PR depends on another PR which is also submitted about 2 years ago. Given another PR is merged recently, so I submitted this PR. So shall we merge this PR first? Once I have bandwidth, I will submit another PR to convert it to typed resource. Does it make sense? |
There was a problem hiding this comment.
@neil-yechenwei Unfortunately I don't believe we can merge this as a new untyped resource. Can you please refactor this as a typed resource? Apologies I didn't notice this earlier in the review cycle.
|
@manicminer , I've converted it to typed resource. Please take another look. Thanks.
|
fixes #7160