Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: porting parts of datafactory over to hashicorp/go-azure-sdk #22409

Merged
merged 14 commits into from
Jul 13, 2023

Conversation

tombuildsstuff
Copy link
Contributor

This PR ports 1 Data Source and 2 Resources in Data Factory over to using hashicorp/go-azure-sdk:

  • Data Source: azurerm_data_factory.
  • Resource: azurerm_data_factory
  • Resource: azurerm_data_factory_managed_private_endpoint

In order to port over Data Sets, Integration Runtimes, Linked Services, Pipelines and Triggers some changes to Pandora are required (since Data Factory uses a different Swagger configuration to other services) - which is tracked in hashicorp/pandora#2551

@tombuildsstuff tombuildsstuff force-pushed the refactor/data-factory-to-go-azure-sdk branch from 86f7097 to ed2445f Compare July 12, 2023 09:33
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏖️

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tombuildsstuff
Copy link
Contributor Author

Tests pass:

Screenshot 2023-07-13 at 12 18 57

@tombuildsstuff tombuildsstuff added this to the v3.65.0 milestone Jul 13, 2023
@tombuildsstuff tombuildsstuff merged commit c044fcf into main Jul 13, 2023
14 checks passed
@tombuildsstuff tombuildsstuff deleted the refactor/data-factory-to-go-azure-sdk branch July 13, 2023 10:19
tombuildsstuff added a commit that referenced this pull request Jul 13, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants