Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_kusto_cluster: deprecate and make engine non functional #22497

Merged
merged 3 commits into from
Jul 21, 2023
Merged

azurerm_kusto_cluster: deprecate and make engine non functional #22497

merged 3 commits into from
Jul 21, 2023

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Jul 13, 2023

No description provided.

WodansSon
WodansSon approved these changes Jul 13, 2023
View reviewed changes
Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@katbyte, I did leave one comment about the deprecation text which is super minor. Either way this LGTM! 🚀

internal/services/kusto/kusto_cluster_resource.go Outdated Show resolved Hide resolved
WodansSon
WodansSon requested changes Jul 13, 2023
View reviewed changes
Copy link
Collaborator

@WodansSon WodansSon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like line 343 needs to be removed since engine is no longer defined:

EngineType: &engine,

@katbyte @WodansSon
Update internal/services/kusto/kusto_cluster_resource.go
399b8b7 
Co-authored-by: Wodans Son <20408400+WodansSon@users.noreply.github.com>
@katbyte katbyte merged commit d51c23f into main Jul 21, 2023
14 checks passed
@katbyte katbyte deleted the kt/kusto-engine branch July 21, 2023 00:33
katbyte added a commit that referenced this pull request Jul 21, 2023
@katbyte
Update CHANGELOG.md #22497
c994c41
@github-actions github-actions bot added this to the v3.66.0 milestone Jul 21, 2023
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@WodansSon WodansSon WodansSon requested changes

Assignees
No one assigned
Labels
documentation service/kusto size/XS
Projects
None yet
Milestone
v3.66.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@katbyte @WodansSon