Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_cognitive_deployment - remove limitation on capacity and update document #22502

Merged
merged 2 commits into from Jul 18, 2023

Conversation

liuwuliuyun
Copy link
Contributor

azurerm_cognitive_deployment

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💾

Optional: true,
ForceNew: true,
Default: 1,
ValidateFunc: validation.IntBetween(1, 10000),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually shouldn't this be validating that it is greater then 0 and not allow negative values?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, let me update this one

Copy link
Member

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @liuwuliuyun, LGTM

@manicminer manicminer merged commit 104e861 into hashicorp:main Jul 18, 2023
23 checks passed
@manicminer manicminer added this to the v3.66.0 milestone Jul 18, 2023
manicminer added a commit that referenced this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for openai deployment quotas
3 participants