Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_web_application_firewall_policy:support log_scrubbing property #22522

Merged
merged 2 commits into from Aug 3, 2023

Conversation

wuxu92
Copy link
Contributor

@wuxu92 wuxu92 commented Jul 14, 2023

--- PASS: TestAccWebApplicationFirewallPolicy_LogScrubbing (282.39s)
PASS

image

@wuxu92 wuxu92 force-pushed the webappfirewall/logscrubbing branch from 01ed5b8 to 200f3ae Compare July 28, 2023 08:43
@wuxu92 wuxu92 changed the title azurerm_web_application_firewall_policy:suports log_scrubbing property azurerm_web_application_firewall_policy:support log_scrubbing property Jul 28, 2023
@wuxu92 wuxu92 marked this pull request as ready for review July 28, 2023 09:16
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from 1 comment 🔨

Comment on lines 383 to 413
},
"rule": {
Type: pluginsdk.TypeList,
Optional: true,
Elem: &pluginsdk.Resource{
Schema: map[string]*pluginsdk.Schema{
"enabled": {
Type: pluginsdk.TypeBool,
Optional: true,
Default: true,
},
"match_variable": {
Type: pluginsdk.TypeString,
Required: true,
ValidateFunc: validation.StringInSlice(
webapplicationfirewallpolicies.PossibleValuesForScrubbingRuleEntryMatchVariable(),
false),
},
"selector_match_operator": {
Type: pluginsdk.TypeString,
Optional: true,
Default: "Equals",
ValidateFunc: validation.StringInSlice(
webapplicationfirewallpolicies.PossibleValuesForScrubbingRuleEntryMatchOperator(),
false),
},
"selector": {
Type: pluginsdk.TypeString,
Optional: true,
Description: "When matchVariable is a collection, operator used to specify which elements in the collection this rule applies to.",
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we use whitespace?

Suggested change
},
"rule": {
Type: pluginsdk.TypeList,
Optional: true,
Elem: &pluginsdk.Resource{
Schema: map[string]*pluginsdk.Schema{
"enabled": {
Type: pluginsdk.TypeBool,
Optional: true,
Default: true,
},
"match_variable": {
Type: pluginsdk.TypeString,
Required: true,
ValidateFunc: validation.StringInSlice(
webapplicationfirewallpolicies.PossibleValuesForScrubbingRuleEntryMatchVariable(),
false),
},
"selector_match_operator": {
Type: pluginsdk.TypeString,
Optional: true,
Default: "Equals",
ValidateFunc: validation.StringInSlice(
webapplicationfirewallpolicies.PossibleValuesForScrubbingRuleEntryMatchOperator(),
false),
},
"selector": {
Type: pluginsdk.TypeString,
Optional: true,
Description: "When matchVariable is a collection, operator used to specify which elements in the collection this rule applies to.",
},
},
"rule": {
Type: pluginsdk.TypeList,
Optional: true,
Elem: &pluginsdk.Resource{
Schema: map[string]*pluginsdk.Schema{
"enabled": {
Type: pluginsdk.TypeBool,
Optional: true,
Default: true,
},
"match_variable": {
Type: pluginsdk.TypeString,
Required: true,
ValidateFunc: validation.StringInSlice(
webapplicationfirewallpolicies.PossibleValuesForScrubbingRuleEntryMatchVariable(),
false),
},
"selector_match_operator": {
Type: pluginsdk.TypeString,
Optional: true,
Default: "Equals",
ValidateFunc: validation.StringInSlice(
webapplicationfirewallpolicies.PossibleValuesForScrubbingRuleEntryMatchOperator(),
false),
},
"selector": {
Type: pluginsdk.TypeString,
Optional: true,
Description: "When matchVariable is a collection, operator used to specify which elements in the collection this rule applies to.",
},

between properties?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! updated with whitespace lines

@katbyte katbyte merged commit bf6b097 into hashicorp:main Aug 3, 2023
23 checks passed
katbyte added a commit that referenced this pull request Aug 3, 2023
@github-actions github-actions bot added this to the v3.68.0 milestone Aug 3, 2023
@wuxu92 wuxu92 deleted the webappfirewall/logscrubbing branch August 4, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants